Page MenuHomeFreeBSD
Differential D4597

hyperv: vmbus: remove the per-channel control_work_queue
ClosedPublic
Actions

Authored by decui_microsoft.com on Dec 16 2015, 1:49 PM.
Tags
None
Referenced Files
F103569919: D4597.diff
Tue, Nov 26, 3:25 PM
F103520117: D4597.id11348.diff
Tue, Nov 26, 1:13 AM
Unknown Object (File)
Thu, Oct 31, 12:36 AM
Unknown Object (File)
Oct 18 2024, 4:37 AM
Unknown Object (File)
Oct 8 2024, 10:31 PM
Unknown Object (File)
Oct 2 2024, 12:37 PM
Unknown Object (File)
Sep 12 2024, 9:55 PM
Unknown Object (File)
Sep 8 2024, 3:17 PM
View All 69 Files
Subscribers
imp

Details

Reviewers
kmacy
howard0su_gmail.com
honzhan_microsoft.com
whu
delphij
royger
Commits
rS292859: hyperv: vmbus: remove the per-channel control_work_queue
Summary

Now vmbus_channel_on_offer() -> vmbus_channel_process_offer() can
safely run on the global hv_vmbus_g_connection.work_queue now.

We remove the per-channel control_work_queue to achieve the proper
serialization of the message handling.

I removed the bogus TODO in vmbus_channel_on_offer(): a vmbus offer
can only come from the parent partition, i.e., the host.

This patch can fix bug
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205156

Signed-off-by: Dexuan Cui <decui@microsoft.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1696
Build 1702: arc lint + arc unit

Event Timeline

decui_microsoft.com updated this revision to Diff 11348.Dec 16 2015, 1:49 PM
decui_microsoft.com retitled this revision from to hyperv: vmbus: remove the per-channel control_work_queue.
decui_microsoft.com updated this object.
decui_microsoft.com added reviewers: whu, royger, delphij, kmacy, howard0su_gmail.com, honzhan_microsoft.com.
Herald added a subscriber: imp. · View Herald TranscriptDec 16 2015, 1:49 PM
howard0su_gmail.com accepted this revision.Dec 21 2015, 2:18 PM
howard0su_gmail.com edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 2:18 PM
delphij accepted this revision.Dec 29 2015, 7:42 AM
delphij edited edge metadata.

Looks good to me.

Closed by commit rS292859: hyperv: vmbus: remove the per-channel control_work_queue (authored by delphij). · Explain WhyDec 29 2015, 7:55 AM
This revision was automatically updated to reflect the committed changes.
decui_microsoft.com added a parent revision: D4596: hyperv: vmbus: run non-blocking message handlers in vmbus_msg_swintr().Dec 29 2015, 8:08 AM

Hi Xin, Thanks for committing this patch!

Can you please commit https://reviews.freebsd.org/D4596 too?
Actually this patch (D4597) depends on D4596. Sorry, I didn't made this clear.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
include/
1 line
vmbus/
32 lines

Diff 11348

View Options

sys/dev/hyperv/include/hyperv.h

Loading...
View Options

sys/dev/hyperv/vmbus/hv_channel_mgmt.c

Loading...