Differential D37397

bhyve: Let BASL compile with raised warnings
ClosedPublic
Actions

Authored by markj on Nov 15 2022, 2:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 13, 4:40 AM

	Unknown Object (File)
	Tue, Jan 13, 4:40 AM

	Unknown Object (File)
	Tue, Jan 13, 4:40 AM

	Unknown Object (File)
	Mon, Jan 12, 10:09 PM

	Unknown Object (File)
	Tue, Dec 30, 3:33 AM

	Unknown Object (File)
	Thu, Dec 25, 10:12 PM

	Unknown Object (File)
	Wed, Dec 24, 9:57 PM

	Unknown Object (File)
	Sat, Dec 20, 4:51 PM

Subscribers

Details

Reviewers

jhb
corvink

Group Reviewers

Commits

rG79135b4788e2: bhyve: Let BASL compile with raised warnings
rGc127c61efa4d: bhyve: Let BASL compile with raised warnings

Summary

Make basl_dump() as unused.
Avoid arithmetic on a void pointer.
Avoid a signed/unsigned comparison with BASL_TABLE_CHECKSUM_LEN_FULL_TABLE.
Ignore warnings about unused parameters from stuff pulled in by acpi.h. In particular, any prototype wrapped by ACPI_DBG_DEPENDENT_RETURN_VOID() will raise such parameters unless ACPI_DEBUG_OUTPUT is defined.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48367
Build 45253: arc lint + arc unit

Event Timeline

markj created this revision.Nov 15 2022, 2:15 PM

Herald added a reviewer: bhyve. · View Herald TranscriptNov 15 2022, 2:15 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Nov 15 2022, 2:15 PM

Harbormaster completed remote builds in B48367: Diff 113149.Nov 15 2022, 2:15 PM

jhb accepted this revision.Nov 15 2022, 7:12 PM

This revision is now accepted and ready to land.Nov 15 2022, 7:12 PM

corvink accepted this revision.Nov 16 2022, 6:29 AM

Closed by commit rGc127c61efa4d: bhyve: Let BASL compile with raised warnings (authored by markj). · Explain WhyNov 18 2022, 7:14 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc127c61efa4d: bhyve: Let BASL compile with raised warnings.

jhb added a commit: rG79135b4788e2: bhyve: Let BASL compile with raised warnings.Jan 26 2023, 8:27 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

5 lines

7 lines

Diff 113149

usr.sbin/bhyve/basl.h

Loading...

usr.sbin/bhyve/basl.c

Loading...