Page MenuHomeFreeBSD
Differential D37393

usb/dwc3: Read the full IDs/version
ClosedPublic
Actions

Authored by manu on Nov 15 2022, 12:58 PM.
Tags
None
Referenced Files
F140921305: D37393.id113181.diff
Mon, Dec 29, 4:11 PM
Unknown Object (File)
Sun, Dec 28, 11:30 PM
Unknown Object (File)
Sun, Dec 28, 10:10 AM
Unknown Object (File)
Fri, Dec 26, 2:57 PM
Unknown Object (File)
Tue, Dec 23, 1:21 PM
Unknown Object (File)
Sat, Dec 20, 3:08 PM
Unknown Object (File)
Thu, Dec 18, 8:12 AM
Unknown Object (File)
Tue, Dec 16, 3:08 PM
View All Files
Subscribers
andrew
imp

Details

Reviewers
andrew
Group Reviewers
arm64
Commits
rG2b42f2138fe4: usb/dwc3: Read the full IDs/version
rG0e87f58bd7e5: usb/dwc3: Read the full IDs/version
Summary

We need to enable some quirks based on the version so read it.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48366
Build 45252: arc lint + arc unit

Event Timeline

manu created this revision.Nov 15 2022, 12:58 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 15 2022, 12:58 PM
manu requested review of this revision.Nov 15 2022, 12:58 PM
Harbormaster completed remote builds in B48360: Diff 113142.Nov 15 2022, 12:58 PM
manu added a child revision: D37394: usb/dwc3: Only force USB2 based on the PHY register and IP version.Nov 15 2022, 1:00 PM
manu added a parent revision: D37392: dwc3: Handle optional clocks.
manu added a reviewer: arm64.
andrew added a subscriber: andrew.Nov 15 2022, 2:03 PM
andrew added inline comments.
sys/dev/usb/controller/dwc3.c
403–413

This looks like it should be a switch statement.

sys/dev/usb/controller/dwc3.h
40–41
manu updated this revision to Diff 113147.Nov 15 2022, 2:05 PM

Convert to switch statement.

Harbormaster completed remote builds in B48365: Diff 113147.Nov 15 2022, 2:05 PM
manu marked an inline comment as done.Nov 15 2022, 2:05 PM
manu updated this revision to Diff 113148.Nov 15 2022, 2:06 PM

Address @andrew's comments.

Harbormaster completed remote builds in B48366: Diff 113148.Nov 15 2022, 2:07 PM
manu marked an inline comment as done.Nov 15 2022, 2:07 PM
andrew accepted this revision.Nov 15 2022, 2:47 PM
This revision is now accepted and ready to land.Nov 15 2022, 2:47 PM
Closed by commit rG0e87f58bd7e5: usb/dwc3: Read the full IDs/version (authored by manu). · Explain WhyNov 16 2022, 10:59 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG0e87f58bd7e5: usb/dwc3: Read the full IDs/version.
manu added a commit: rG2b42f2138fe4: usb/dwc3: Read the full IDs/version.Feb 2 2023, 11:20 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
controller/
12 lines
30 lines

Diff 113148

View Options

sys/dev/usb/controller/dwc3.h

Loading...
View Options

sys/dev/usb/controller/dwc3.c

Loading...