Page MenuHomeFreeBSD
Differential D37392

dwc3: Handle optional clocks
ClosedPublic
Actions

Authored by manu on Nov 15 2022, 12:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 17 2024, 5:11 AM
Unknown Object (File)
Mar 17 2024, 5:11 AM
Unknown Object (File)
Mar 17 2024, 5:10 AM
Unknown Object (File)
Mar 14 2024, 12:08 PM
Unknown Object (File)
Jan 18 2024, 7:51 AM
Unknown Object (File)
Jan 12 2024, 3:06 AM
Unknown Object (File)
Dec 20 2023, 8:05 AM
Unknown Object (File)
Oct 4 2023, 1:10 PM
View All 20 Files
Subscribers
andrew
imp

Details

Reviewers
andrew
Group Reviewers
arm64
Commits
rG2908718700b5: dwc3: Handle optional clocks
rG0a5f342aa5a0: dwc3: Handle optional clocks
Summary

Usually dwc3 needs a glue node that contain the SoC specific clocks/resets.
For some reason the RK3328 DTS doesn't have this glue node and the clocks
are specified in the dwc3 node directly.
The bindings says that it is allowed but doesn't specified some strict names
for them.
Add a specific case for RK3328 based on the compatible string.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.Nov 15 2022, 12:58 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 15 2022, 12:58 PM
manu requested review of this revision.Nov 15 2022, 12:58 PM
Harbormaster completed remote builds in B48359: Diff 113141.Nov 15 2022, 12:58 PM
manu added a child revision: D37393: usb/dwc3: Read the full IDs/version.Nov 15 2022, 1:00 PM
manu added a reviewer: arm64.
manu added a child revision: D37396: arm64/rk_dwc3: Remove RK3328 support.Nov 15 2022, 2:02 PM
andrew added a subscriber: andrew.Nov 15 2022, 3:12 PM
andrew added inline comments.
sys/dev/usb/controller/dwc3.c
405

Is there a reason to put this here rather than using a subclass?

manu added inline comments.Nov 15 2022, 3:22 PM
sys/dev/usb/controller/dwc3.c
405

Because this is the only difference and other rockchip SoC (haven't looked) will have the same clock name (other socs too).
So it's easier.

andrew accepted this revision.Nov 15 2022, 3:27 PM
This revision is now accepted and ready to land.Nov 15 2022, 3:27 PM
Closed by commit rG0a5f342aa5a0: dwc3: Handle optional clocks (authored by manu). · Explain WhyNov 16 2022, 10:58 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG0a5f342aa5a0: dwc3: Handle optional clocks.
manu added a commit: rG2908718700b5: dwc3: Handle optional clocks.Feb 2 2023, 11:20 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
controller/
40 lines

Diff 113179

View Options

sys/dev/usb/controller/dwc3.c

Loading...