Page MenuHomeFreeBSD
Differential D37394

usb/dwc3: Only force USB2 based on the PHY register and IP version
ClosedPublic
Actions

Authored by manu on Nov 15 2022, 12:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 17 2024, 5:07 AM
Unknown Object (File)
Mar 17 2024, 5:07 AM
Unknown Object (File)
Mar 17 2024, 5:07 AM
Unknown Object (File)
Mar 14 2024, 12:04 PM
Unknown Object (File)
Feb 4 2024, 2:44 PM
Unknown Object (File)
Jan 12 2024, 3:06 AM
Unknown Object (File)
Dec 23 2023, 12:27 AM
Unknown Object (File)
Nov 14 2023, 9:41 PM
View All 24 Files
Subscribers
andrew
imp

Details

Reviewers
andrew
Group Reviewers
arm64
Commits
rGe83f76ac2188: usb/dwc3: Only force USB2 based on the PHY register and IP version
rGd47f5f2886f0: usb/dwc3: Only force USB2 based on the PHY register and IP version
Summary

We shouldn't force USB2 only based on if we have an external PHY.
The internal PHY register tell us what link speed we can acheive
and we need to force USB2 only if it cannot do USB3.
This is only available after revision 0x290A of the dwc3 IP.

Fixed: 1331c0f44b6a ("Add support for RockChip RK356X to DWC3 driver.")
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.Nov 15 2022, 12:59 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 15 2022, 12:59 PM
manu requested review of this revision.Nov 15 2022, 12:59 PM
Harbormaster completed remote builds in B48361: Diff 113143.Nov 15 2022, 12:59 PM
manu added a child revision: D37395: arm64/rockchip: Remove rk3328-dwc3 overlays.Nov 15 2022, 1:00 PM
manu added a parent revision: D37393: usb/dwc3: Read the full IDs/version.
manu added a reviewer: arm64.
andrew added a subscriber: andrew.Nov 15 2022, 3:07 PM
andrew added inline comments.
sys/dev/usb/controller/dwc3.c
462

What revision is 0x290a?

sys/dev/usb/controller/dwc3.h
113

We should clean the other macros that take an argument to use ((x) ...) at some stage.

manu added inline comments.Nov 15 2022, 3:20 PM
sys/dev/usb/controller/dwc3.c
462

It's 0x290a :)
There is no other info that the revision field in the ID register.

sys/dev/usb/controller/dwc3.h
113

I'll do that in a later commit

andrew accepted this revision.Nov 16 2022, 9:51 AM
This revision is now accepted and ready to land.Nov 16 2022, 9:51 AM
Closed by commit rGd47f5f2886f0: usb/dwc3: Only force USB2 based on the PHY register and IP version (authored by manu). · Explain WhyNov 16 2022, 10:59 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rGd47f5f2886f0: usb/dwc3: Only force USB2 based on the PHY register and IP version.
manu added a commit: rGe83f76ac2188: usb/dwc3: Only force USB2 based on the PHY register and IP version.Feb 2 2023, 11:26 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
controller/
5 lines
19 lines

Diff 113182

View Options

sys/dev/usb/controller/dwc3.h

Loading...
View Options

sys/dev/usb/controller/dwc3.c

Loading...