Details
- Reviewers
pauamma_gundo.com - Group Reviewers
network manpages - Commits
- rG02b958b19535: netlink: add netlink user documentation.
rG7366c0a49c9a: netlink: add netlink user documentation.
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Warnings Severity Location Code Message Warning share/man/man4/genetlink.4:147 SPELL1 Possible Spelling Mistake Warning share/man/man4/netlink.4:344 SPELL1 Possible Spelling Mistake Warning share/man/man4/rtnetlink.4:181 SPELL1 Possible Spelling Mistake Warning share/man/man4/rtnetlink.4:518 SPELL1 Possible Spelling Mistake - Unit
No Test Coverage - Build Status
Buildable 47851 Build 44738: arc lint + arc unit
Event Timeline
Will review the rest later.
| share/man/man4/genetlink.4 | ||
|---|---|---|
| 31 | ||
| 42 | ||
| 43–44 | Maybe use "string family name" throughout instead? Having both a string identifier and another id(entifier) of an unspecified type is confusing. | |
| 45–46 | "the application" or "applications" (leaning toward the latter). | |
| 47 | ||
| 49 | ||
| 52 | Not sure "families" is right, but there's definitely a word missing. | |
| 63–65 | Or remove "The". | |
| 68 | Same as above. | |
| 70 | ||
| 72 | Needs to say which family id it has, here or somewhere. Here is probably best. | |
| 80 | What I think you mean. | |
Done for this round.
| share/man/man4/netlink.4 | ||
|---|---|---|
| 56 | VNETs? Not other kinds of network? | |
| 67 | ||
| 83 | ||
| 111 | Spurious space. | |
| 275 | ||
| share/man/man4/rtnetlink.4 | ||
| 103 | ||
| 104 | ||
| 109 | VNET? | |
| 134–135 | ||
| 221 | Or "The required objects are" if more than 1. | |
| 289 | ||
| 292 | Is this really restricted to VNETs? | |
| 295 | ||
| 308 | For brevity and consistency with later ones. | |
| 310 | ||
| 340 | Is there an active 802.1x standard other than 802.11? | |
| 420–422 | US spelling | |
| 436 | (or get rid of "The") | |
| 453 | ||
| 462 | ||
| 469 | ||
| 475 | Also, VNET? | |
| 491 | ||
| 493 | ||
| 503 | ||
| share/man/man4/netlink.4 | ||
|---|---|---|
| 235 | NETLINK_DROP_MEMBERSHIP | |
| share/man/man4/genetlink.4 | ||
|---|---|---|
| 72 | GENL_ID_CTRL is the actual Id. I’d rather not specify its value here, to avoid any encouragement for using number instead of a header constant. Also typically we don’t provide such mappings in man page. Thoughts? | |
| share/man/man4/netlink.4 | ||
| 56 | Vnets. Or namespaces in Linux land | |
| share/man/man4/rtnetlink.4 | ||
| 109 | Yes. | |
| 292 | Well, yes. Similar to ifconfig. There is a socket option & attribute that allows to interact with the objects in the VNET different from the current one, but it’s not implemented yet. | |
| 340 | A lot (even too many, maybe). 802.1D is about bridging, including loop prevention protocols, .1Q is about vlans and so on. 802.1X is a standard handling authentication in LAN / wireless. If network is using it, there will be a temporary state when an interface is already able to send/receive frames, but encryption is not negotiated yet. This condition is an example of the aforementioned state. | |
Other than a few nits all fixable on commit, LGTM. If it matches the implementation, it's good to go.
| share/man/man4/genetlink.4 | ||
|---|---|---|
| 28 | Bump on commit. | |
| 72 | Never mind. I misparsed the whole paragraph. Ignore the noise. | |
| share/man/man4/netlink.4 | ||
| 112 | "32-bit" when the length is in bytes doesn't look quite right. For consistency, I'd change the other occurrences as well. | |
| 200 | "message", maybe? | |
| 277 | ||
| 341 | ||
| share/man/man4/netlink.4 | ||
|---|---|---|
| 341 | Mm, I'm a bit unsure about this one. Technically it's indeed an OS feature, but it sounds a bit abstract to me. We typically say, "X has IPv6 [protocol] support" or "X has TCP [protocol]" and refer to the word "feature" when there is no better word to describe it. Thoughts? | |
| share/man/man4/netlink.4 | ||
|---|---|---|
| 341 | Well, there's definitely a word missing, so we need to choose one to add. I was trying to avoid repeating "protocol", but that would work. | |