libbegemot: Disable -Wuse-after-free.
ClosedPublic
Actions

Authored by jhb on Sep 29 2022, 10:33 PM.

Details

Reviewers

emaste
imp

Commits

rG65e28bfeaacc: libbegemot: Disable -Wuse-after-free.
rG996ee9659763: libbegemot: Disable -Wuse-after-free.

Summary

The _xrealloc() function prints pointer values for internal assertion
failures and in one case does so after it has freed the pointer.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47633
Build 44520: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Sep 29 2022, 10:33 PM

jhb created this revision.

Harbormaster completed remote builds in B47633: Diff 111237.Sep 29 2022, 10:33 PM

jhb added a parent revision: D36818: libzpool: Disable -Wuse-after-free for dbuf.c..Sep 29 2022, 10:33 PM

jhb added a child revision: D36820: libedit: Disable -Wuse-after-free for chartype.c..

emaste accepted this revision.Sep 29 2022, 11:32 PM

This revision is now accepted and ready to land.Sep 29 2022, 11:32 PM

Closed by commit rG996ee9659763: libbegemot: Disable -Wuse-after-free. (authored by jhb). · Explain WhyOct 3 2022, 11:13 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG996ee9659763: libbegemot: Disable -Wuse-after-free..

Would saving the pointer address in a local uinptr_t/size_t fix the warning?

Something like this: https://godbolt.org/z/xKxnheh5r

jhb added a commit: rG65e28bfeaacc: libbegemot: Disable -Wuse-after-free..Nov 11 2022, 6:39 PM

Revision Contents
Changeset List

Path

Size

lib/

libbegemot/

Makefile

2 lines

Diff 111237

View Options

libbegemot: Disable -Wuse-after-free.ClosedPublicActions