Page MenuHomeFreeBSD
Differential D36754

arm atomic-v6.h: Use eoreqs rather than eorseq to appease GNU as.
AcceptedPublic
Actions

Authored by jhb on Sep 27 2022, 5:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 10, 1:26 PM
Unknown Object (File)
Sun, Jul 6, 10:31 PM
Unknown Object (File)
Mon, Jun 30, 11:08 AM
Unknown Object (File)
Sun, Jun 29, 4:21 AM
Unknown Object (File)
Mon, Jun 16, 11:55 AM
Unknown Object (File)
Mar 22 2025, 8:41 AM
Unknown Object (File)
Mar 11 2025, 12:46 AM
Unknown Object (File)
Feb 27 2025, 8:03 AM
View All 59 Files
Subscribers
andrew
mmel

Details

Reviewers
imp
manu
andrew
Summary

GNU as seems to require the 's' flag after the condition code
rather than before it which seems consistent with the instruction
description for EOR in the ARM ARM. Curiously, however, objdump -d
from binutils displays the instruction as eorseq.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47569
Build 44456: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 27 2022, 5:42 PM
Herald added a subscriber: andrew. · View Herald TranscriptSep 27 2022, 5:42 PM
jhb requested review of this revision.Sep 27 2022, 5:42 PM
Harbormaster completed remote builds in B47569: Diff 111096.Sep 27 2022, 5:42 PM
imp accepted this revision.Sep 27 2022, 5:43 PM

If it build with both clang and gcc, this is fine

This revision is now accepted and ready to land.Sep 27 2022, 5:43 PM
andrew added a comment.Sep 27 2022, 9:02 PM

eorseq is correct as it's created from the eors instruction and eq condition code.

My copy of the ARM ARM (for Armv8/9) has it as EORS{<c>}{<q>} where <c> is the condition code. The <q> is unimportant here as it's to tell the assembler to use a 16 or 32 bit Thumb instruction.

I guess GCC isn't emitting .syntax unified to enable Unified Assembler Language.

brooks mentioned this in D45193: arm: fail early on gcc builds.May 14 2024, 12:11 AM
brooks mentioned this in rG4c0dfd5959bd: arm: fail early on gcc builds.May 17 2024, 4:02 PM
mmel added a subscriber: mmel.May 17 2024, 5:19 PM

Hmm, shouldn't the -masm-syntax-unified be added to gcc CFLAGS? (just guessing, untested)

Herald added a reviewer: andrew. · View Herald TranscriptMay 17 2024, 5:19 PM
jhb added a comment.May 17 2024, 7:22 PM
In D36754#1031820, @mmel wrote:

Hmm, shouldn't the -masm-syntax-unified be added to gcc CFLAGS? (just guessing, untested)

Yes, I just haven't gotten back to testing the right CFLAGS fix.

Revision Contents
Changeset List

PathSize
sys/
arm/
include/
8 lines

Diff 111096

View Options

sys/arm/include/atomic-v6.h

Loading...