Differential D36675

amd64: Ignore 1GB mappings in pmap_advise()
ClosedPublic
Actions

Authored by markj on Sep 22 2022, 11:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 7, 10:08 PM

	Unknown Object (File)
	Fri, Aug 7, 10:52 AM

	Unknown Object (File)
	Thu, Aug 6, 1:44 PM

	Unknown Object (File)
	Thu, Aug 6, 6:21 AM

	Unknown Object (File)
	Wed, Aug 5, 2:23 AM

	Unknown Object (File)
	Wed, Jul 29, 8:17 AM

	Unknown Object (File)
	Tue, Jul 28, 3:59 PM

	Unknown Object (File)
	Tue, Jul 28, 7:56 AM

Subscribers

Details

Reviewers

alc
dougm
kib

Commits

rG4551cbbe9906: amd64: Ignore 1GB mappings in pmap_advise()

Summary

This assertion can be triggered by usermode since vm_map_madvise()
doesn't force advice to be applied to an entire largepage mapping. I
can't see any reason not to permit it, however, since MADV_DONTNEED and
_FREE are advisory and we can simply do nothing when a 1GB mapping is
encountered.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47498
Build 44385: arc lint + arc unit

Event Timeline

markj created this revision.Sep 22 2022, 11:08 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 22 2022, 11:08 PM

markj requested review of this revision.Sep 22 2022, 11:08 PM

Harbormaster completed remote builds in B47498: Diff 110869.Sep 22 2022, 11:08 PM

kib accepted this revision.Sep 22 2022, 11:53 PM

This revision is now accepted and ready to land.Sep 22 2022, 11:53 PM

Shouldn't the same change be made on arm64?

Closed by commit rG4551cbbe9906: amd64: Ignore 1GB mappings in pmap_advise() (authored by markj). · Explain WhySep 24 2022, 1:38 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG4551cbbe9906: amd64: Ignore 1GB mappings in pmap_advise().

In D36675#832960, @alc wrote:

Shouldn't the same change be made on arm64?

Yes, I committed it as a follow-up.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

7 lines

Diff 110869

sys/amd64/amd64/pmap.c

Loading...