Differential D36675

amd64: Ignore 1GB mappings in pmap_advise()
ClosedPublic
Actions

Authored by markj on Sep 22 2022, 11:08 PM.

Tags

None

Referenced Files

	F111020687: D36675.id.diff
	Wed, Feb 26, 7:53 AM

	Unknown Object (File)
	Tue, Feb 25, 4:37 AM

	Unknown Object (File)
	Mon, Feb 24, 1:09 PM

	Unknown Object (File)
	Sun, Feb 23, 11:34 PM

	Unknown Object (File)
	Jan 20 2025, 11:01 PM

	Unknown Object (File)
	Jan 20 2025, 10:47 PM

	Unknown Object (File)
	Jan 16 2025, 6:30 PM

	Unknown Object (File)
	Dec 27 2024, 7:14 AM

View All 64 Files

Subscribers

Details

Reviewers

alc
dougm
kib

Commits

rG4551cbbe9906: amd64: Ignore 1GB mappings in pmap_advise()

Summary

This assertion can be triggered by usermode since vm_map_madvise()
doesn't force advice to be applied to an entire largepage mapping. I
can't see any reason not to permit it, however, since MADV_DONTNEED and
_FREE are advisory and we can simply do nothing when a 1GB mapping is
encountered.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Sep 22 2022, 11:08 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 22 2022, 11:08 PM

markj requested review of this revision.Sep 22 2022, 11:08 PM

Harbormaster completed remote builds in B47498: Diff 110869.Sep 22 2022, 11:08 PM

kib accepted this revision.Sep 22 2022, 11:53 PM

This revision is now accepted and ready to land.Sep 22 2022, 11:53 PM

Shouldn't the same change be made on arm64?

Closed by commit rG4551cbbe9906: amd64: Ignore 1GB mappings in pmap_advise() (authored by markj). · Explain WhySep 24 2022, 1:38 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG4551cbbe9906: amd64: Ignore 1GB mappings in pmap_advise().

In D36675#832960, @alc wrote:

Shouldn't the same change be made on arm64?

Yes, I committed it as a follow-up.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

7 lines

Diff 110916

sys/amd64/amd64/pmap.c

Loading...