stand: i386: take into account disk sector size for blk calculation
ClosedPublic
Actions

Authored by kevans on Sep 8 2022, 12:36 AM.

Details

Reviewers

tsoome
imp
jhb
manu

Commits

rG72291cee075d: stand: i386: take into account disk sector size for blk calculation

Summary

disk_blocks assumes BIOSDISK_SECSIZE, but the media may not be using
it. In particular, bioscd on Parallels presents a 2K sector size, so
we end up with a short disk_blocks and subsequent validation fails when
trying to read /boot/lua.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47289
Build 44176: arc lint + arc unit

Event Timeline

kevans created this revision.Sep 8 2022, 12:36 AM

Herald added a reviewer: manu. · View Herald TranscriptSep 8 2022, 12:36 AM

Herald added a subscriber: dab. · View Herald Transcript

kevans requested review of this revision.Sep 8 2022, 12:36 AM

Harbormaster completed remote builds in B47289: Diff 110338.Sep 8 2022, 12:37 AM

Simplify, just divide; bd_sectorsize should always be a multiple of 512.

Harbormaster completed remote builds in B47290: Diff 110340.Sep 8 2022, 1:34 AM

imp accepted this revision.Sep 8 2022, 1:42 AM

This revision is now accepted and ready to land.Sep 8 2022, 1:42 AM

Thanks!

Closed by commit rG72291cee075d: stand: i386: take into account disk sector size for blk calculation (authored by kevans). · Explain WhySep 8 2022, 3:06 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG72291cee075d: stand: i386: take into account disk sector size for blk calculation.

Revision Contents
Changeset List

Path

Size

stand/

i386/

libi386/

biosdisk.c

3 lines

Diff 110338

View Options

stand/i386/libi386/biosdisk.c

stand: i386: take into account disk sector size for blk calculationClosedPublicActions