Page MenuHomeFreeBSD
Differential D36134

tools/build: Provide fls* when cross-building on Linux
ClosedPublic
Actions

Authored by jrtc27 on Aug 11 2022, 12:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 7:34 AM
Unknown Object (File)
Fri, Sep 11, 1:53 AM
Unknown Object (File)
Wed, Sep 9, 1:42 PM
Unknown Object (File)
Mon, Sep 7, 10:34 PM
Unknown Object (File)
Sun, Sep 6, 2:14 AM
Unknown Object (File)
Sat, Sep 5, 9:06 AM
Unknown Object (File)
Thu, Sep 3, 11:37 PM
Unknown Object (File)
Thu, Sep 3, 5:30 PM
View All Files
Subscribers
arichardson
markj

Details

Reviewers
imp
emaste
arichardson
Commits
rG548f8a657bc1: tools/build: Provide fls* when cross-building on Linux
Summary

flsll is needed for makefs's new ZFS support, and the others are added
for completeness.

Fixes: 240afd8c1fcc ("makefs: Add ZFS support")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46851
Build 43740: arc lint + arc unit

Event Timeline

jrtc27 requested review of this revision.Aug 11 2022, 12:03 AM
jrtc27 created this revision.
Harbormaster completed remote builds in B46851: Diff 109140.Aug 11 2022, 12:03 AM
jrtc27 added a child revision: D36135: makefs: Fix issues building as a cross-tool on non-FreeBSD.Aug 11 2022, 12:04 AM
emaste accepted this revision.Aug 11 2022, 12:04 AM
emaste added a subscriber: markj.

No objection

This revision is now accepted and ready to land.Aug 11 2022, 12:05 AM
arichardson accepted this revision.Aug 11 2022, 10:44 PM
arichardson added a subscriber: arichardson.

LGTM. We could also go for inline functions that call the __builtin functions but this is simpler.

Closed by commit rG548f8a657bc1: tools/build: Provide fls* when cross-building on Linux (authored by jrtc27). · Explain WhyAug 18 2022, 1:47 AM
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rG548f8a657bc1: tools/build: Provide fls* when cross-building on Linux.

Revision Contents
Changeset List

PathSize
tools/
build/
2 lines
cross-build/
include/
linux/
40 lines

Diff 109140

View Options

tools/build/Makefile

Loading...
View Options

tools/build/cross-build/include/linux/strings.h

Loading...