Page MenuHomeFreeBSD

makefs: Fix issues building as a cross-tool on non-FreeBSD
ClosedPublic

Authored by jrtc27 on Aug 11 2022, 12:03 AM.
Tags
None
Referenced Files
F132319520: D36135.diff
Wed, Oct 15, 8:55 PM
Unknown Object (File)
Sep 1 2025, 10:32 PM
Unknown Object (File)
Aug 14 2025, 11:56 PM
Unknown Object (File)
Aug 14 2025, 9:36 AM
Unknown Object (File)
Aug 4 2025, 11:32 PM
Unknown Object (File)
Aug 3 2025, 3:38 PM
Unknown Object (File)
Aug 2 2025, 2:45 AM
Unknown Object (File)
Jul 29 2025, 7:23 AM

Details

Summary

This adds missing includes, uses the standard dirent.h rather than the
BSD-specific sys/dirent.h subset (which works on macOS but not Linux)
and works around Linux's lack of st_birthtim.

This allows usr.sbin/makefs to be added to LOCAL_XTOOL_DIRS again on
macOS and Linux so that disk images can be cross-built.

Fixes: 240afd8c1fcc ("makefs: Add ZFS support")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 11 2022, 12:34 AM

Oh nice, didn't see these changes, I just went for the simple workaround in D36089