Page MenuHomeFreeBSD
Differential D35992

wg_noise: Drop atomics for kp_can_send.
AbandonedPublic
Actions

Authored by jhb on Jul 29 2022, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 2, 8:47 PM
Unknown Object (File)
Wed, Oct 29, 9:21 AM
Unknown Object (File)
Wed, Oct 29, 8:59 AM
Unknown Object (File)
Mon, Oct 27, 11:37 PM
Unknown Object (File)
Oct 26 2025, 8:50 AM
Unknown Object (File)
Oct 25 2025, 1:20 AM
Unknown Object (File)
Oct 23 2025, 10:51 PM
Unknown Object (File)
Oct 17 2025, 7:07 PM
View All 69 Files
Subscribers
emaste
imp

Details

Reviewers
markj
Summary

Using atomics for only load and store seem pointless. The only ones
that might matter are covered by fences in epoch_*.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46684
Build 43573: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 29 2022, 4:57 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 29 2022, 4:57 PM
jhb requested review of this revision.Jul 29 2022, 4:57 PM
Harbormaster completed remote builds in B46684: Diff 108717.Jul 29 2022, 4:57 PM
jhb added a parent revision: D35991: wg: Remove some atomics for kp pointers..Jul 29 2022, 4:57 PM
jhb added a child revision: D35993: wg_noise: Use atomic(9) for kp_nonce_send/recv..
emaste added a subscriber: emaste.Aug 2 2022, 4:30 PM
jhb edited parent revisions, added: D36913: wg: Trim compat shims for versions older than current stable/13.; removed: D35991: wg: Remove some atomics for kp pointers..Oct 7 2022, 10:03 PM
jhb removed a parent revision: D36913: wg: Trim compat shims for versions older than current stable/13..Oct 7 2022, 10:05 PM
emaste added a comment.May 6 2024, 5:21 PM

Is this patch still relevant?

jhb added a comment.May 6 2024, 5:30 PM

It's not really critical.

markj added a comment.May 6 2024, 6:18 PM

I think this is superseded by commit e32e1a160e01a no?

jhb abandoned this revision.May 7 2024, 4:40 PM
In D35992#1028570, @markj wrote:

I think this is superseded by commit e32e1a160e01a no?

Kind of. This change drops atomics that I think aren't really needed, but they are also fairly harmless. It is true that initially when trying to switch wg(4) to atomic(9) we didn't support bools for atomic(9), but I ended up adding bools to atomic(9) so we could switch without having to remove any. I still think these atomics aren't needed, per se but they are also pretty harmless.

Revision Contents
Changeset List

PathSize
sys/
dev/
wg/
16 lines

Diff 108717

View Options

sys/dev/wg/wg_noise.c

Loading...