Page MenuHomeFreeBSD
Differential D35829

LinuxKPI: extend kfifo to be usable by a driver
ClosedPublic
Actions

Authored by bz on Jul 16 2022, 12:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 23, 12:12 PM
Unknown Object (File)
Sat, May 23, 12:12 PM
Unknown Object (File)
Sun, May 17, 11:24 PM
Unknown Object (File)
Sun, May 17, 11:24 PM
Unknown Object (File)
Sun, May 17, 11:23 PM
Unknown Object (File)
Fri, May 8, 1:24 AM
Unknown Object (File)
Wed, May 6, 1:42 PM
Unknown Object (File)
Sun, May 3, 5:50 AM
View All Files
Subscribers
emaste
imp
linuxkpi

Details

Reviewers
manu
wulf
• hselasky
Commits
rG855405e1750d: LinuxKPI: extend kfifo to be usable
rG4a7e8c7bd40b: LinuxKPI: extend kfifo to be usable
Summary

Implement some basic needs for an actual driver using kfifo.

MFC after: 2 weeks

Test Plan

I had this in user space initially and tested it and it seemed to
work as expected.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46453
Build 43342: arc lint + arc unit

Event Timeline

bz created this revision.Jul 16 2022, 12:40 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptJul 16 2022, 12:40 AM
bz requested review of this revision.Jul 16 2022, 12:40 AM
Harbormaster completed remote builds in B46453: Diff 108216.Jul 16 2022, 12:40 AM
• hselasky added inline comments.Jul 16 2022, 10:24 AM
sys/compat/linuxkpi/common/include/linux/kfifo.h
91

Is there a chance of counters wrapping around?

Where is first decremented?

bz added inline comments.Jul 17 2022, 1:03 PM
sys/compat/linuxkpi/common/include/linux/kfifo.h
91

First is decremented right below there if it rolls over. It's a FIFO--first and last just move forward (or wrap around).

• hselasky accepted this revision.Jul 17 2022, 6:15 PM

Now I see. Looks good to me.

This revision is now accepted and ready to land.Jul 17 2022, 6:15 PM
bz added a comment.Jul 18 2022, 11:17 AM

I've done a build against drm-kmod master but I'll wait to hear back from @manu or @wulf on whether it's okay for them too.

wulf accepted this revision.Jul 19 2022, 10:42 PM

It builds for me on master, 5.10-lts and 5.4-lts branches

Closed by commit rG4a7e8c7bd40b: LinuxKPI: extend kfifo to be usable (authored by bz). · Explain WhyAug 18 2022, 8:29 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG4a7e8c7bd40b: LinuxKPI: extend kfifo to be usable.
bz added a commit: rG855405e1750d: LinuxKPI: extend kfifo to be usable.Sep 21 2022, 2:03 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
89 lines

Diff 108216

View Options

sys/compat/linuxkpi/common/include/linux/kfifo.h

Loading...