libvmm: add __BEGIN_DECLS/__END_DECLS for linking with c++ binaries
ClosedPublic
Actions

Authored by gusev.vitaliy_gmail.com on Jul 5 2022, 3:14 PM.

Details

Reviewers

jhb
markj
imp

Group Reviewers

bhyve

Commits

rG1228a047aa65: libvmm: add __BEGIN_DECLS/__END_DECLS for linking with c++ binaries

Summary

Sponsored by vStack.

Test Plan

$ cat vmopen.cpp

#include <dlfcn.h>
#include <err.h>
#include <vmmapi.h>

typedef void (*vm_close_fn)(struct vmctx *ctx);
int main(int argc, char *argv[])
{
	const char *vmname = argc > 1 ? argv[1] : "-";
	struct vmctx *ctx;
	vm_close_fn __vm_close = (vm_close_fn)dlsym(RTLD_NEXT, "vm_close");

	ctx = vm_open(vmname);

	if (ctx == NULL)
		err(1, "cannot open vm device: %s", vmname);

	if (__vm_close)
		__vm_close(ctx);
}

Compilation and linking

$ c++ vmopen.cpp -I /data/freebsd/HEAD/lib/libvmmapi/ -L /data/freebsd/HEAD/lib/libvmmapi/ -lvmmapi

Without patch command above produces:

ld: error: undefined symbol: vm_open(char const*)

With patch - success.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

gusev.vitaliy_gmail.com created this revision.Jul 5 2022, 3:14 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJul 5 2022, 3:14 PM

Herald added subscribers: rgrimes, imp. · View Herald Transcript

gusev.vitaliy_gmail.com requested review of this revision.Jul 5 2022, 3:14 PM

markj accepted this revision as: markj.Jul 5 2022, 3:50 PM

markj added inline comments.

lib/libvmmapi/vmmapi.h
37	Conventionally, cdefs.h is included first (see style(9)). So: #include <sys/cdefs.h> #include <sys/param.h> #include ...

This revision is now accepted and ready to land.Jul 5 2022, 3:50 PM

Corrected include order according to Mark's comment.

This revision now requires review to proceed.Jul 5 2022, 7:42 PM

@markj Could you approve again and commit?

imp accepted this revision.Jul 5 2022, 8:29 PM

This revision is now accepted and ready to land.Jul 5 2022, 8:29 PM

jhb accepted this revision.Jul 6 2022, 6:39 PM

Closed by commit rG1228a047aa65: libvmm: add __BEGIN_DECLS/__END_DECLS for linking with c++ binaries (authored by gusev.vitaliy_gmail.com, committed by markj). · Explain WhyJul 11 2022, 7:59 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG1228a047aa65: libvmm: add __BEGIN_DECLS/__END_DECLS for linking with c++ binaries.

Revision Contents
Changeset List

Path

Size

lib/

libvmmapi/

vmmapi.h

3 lines

Diff 107801

View Options

libvmm: add __BEGIN_DECLS/__END_DECLS for linking with c++ binariesClosedPublicActions