sfxge: fix pointer parameter/value signedness mismatch warnings
ClosedPublic
Actions

Authored by arybchik on Dec 5 2015, 8:29 AM.

Details

Reviewers

philip
np
gnn
bz

Commits

rS291926: sfxge: fix pointer parameter/value signedness mismatch warnings

Summary

TLV routines use 'uint8_t *', NVRAM code uses caddr_t. Just cast to
required type to fix the warning.

Required to build with -Werror=pointer-signg.

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

Build tested. Driver loaded/unloaded.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 1420
Build 1425: arc lint + arc unit

Event Timeline

arybchik updated this revision to Diff 10764.Dec 5 2015, 8:29 AM

arybchik retitled this revision from to sfxge: fix pointer parameter/value signedness mismatch warnings.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, philip, bz, np.

Herald added a subscriber: imp. · View Herald TranscriptDec 5 2015, 8:29 AM

gnn accepted this revision.Dec 5 2015, 7:08 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Dec 5 2015, 7:08 PM

Closed by commit rS291926: sfxge: fix pointer parameter/value signedness mismatch warnings (authored by arybchik). · Explain WhyDec 7 2015, 6:07 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

hunt_nvram.c

16 lines

Diff 10764

View Options

head/sys/dev/sfxge/common/hunt_nvram.c

sfxge: fix pointer parameter/value signedness mismatch warningsClosedPublicActions