pf: Make sure that pfi_update_status() always zeros counters
ClosedPublic
Actions

Authored by markj on Jun 29 2022, 3:28 PM.

Details

Reviewers

Commits

rG86bd7f67c31f: pf: Make sure that pfi_update_status() always zeros counters
rG333670372ffe: pf: Make sure that pfi_update_status() always zeros counters

Summary

pfi_update_status() can return early if the status interface doesn't
exist. But in this case pf_getstatus() was copying uninitialized stack
memory into the output nvlist.

Reported by: Jenkins (KMSAN job)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 29 2022, 3:28 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptJun 29 2022, 3:28 PM

markj requested review of this revision.Jun 29 2022, 3:28 PM

Harbormaster completed remote builds in B46181: Diff 107555.Jun 29 2022, 3:28 PM

markj added a child revision: D35660: pf: Ensure that pfiio_name is always nul terminated.Jun 29 2022, 3:28 PM

kp accepted this revision.Jun 29 2022, 5:26 PM

This revision is now accepted and ready to land.Jun 29 2022, 5:26 PM

Closed by commit rG333670372ffe: pf: Make sure that pfi_update_status() always zeros counters (authored by markj). · Explain WhyJun 30 2022, 2:32 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG333670372ffe: pf: Make sure that pfi_update_status() always zeros counters.

emaste added a commit: rG86bd7f67c31f: pf: Make sure that pfi_update_status() always zeros counters.Aug 29 2022, 1:07 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_if.c

9 lines

Diff 107599

View Options

pf: Make sure that pfi_update_status() always zeros countersClosedPublicActions