Paths

Table of Contentst

Differential D31355

xen/intr: hand off closing of ports sooner
Needs ReviewPublic
Actions

Authored by ehem_freebsd_m5p.com on Jul 30 2021, 2:27 AM.

Tags

None

Referenced Files

	F106239931: D31355.diff
	Fri, Dec 27, 6:00 PM

	Unknown Object (File)
	Mon, Dec 23, 6:55 AM

	Unknown Object (File)
	Nov 19 2024, 10:27 AM

	Unknown Object (File)
	Nov 17 2024, 7:27 AM

	Unknown Object (File)
	Nov 15 2024, 9:02 AM

	Unknown Object (File)
	Nov 15 2024, 8:58 AM

	Unknown Object (File)
	Nov 15 2024, 8:48 AM

	Unknown Object (File)
	Nov 15 2024, 7:32 AM

View All 96 Files

Subscribers

Details

Reviewers

Summary

Since xi_close now comes along for the ride, move some cases of closing
the port on failure into xen_intr_bind_isrc().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46175
Build 43064: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Jul 30 2021, 2:27 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 30 2021, 2:27 AM

ehem_freebsd_m5p.com requested review of this revision.Jul 30 2021, 2:27 AM

Harbormaster completed remote builds in B40751: Diff 92981.Jul 30 2021, 2:27 AM

ehem_freebsd_m5p.com added a parent revision: D31188: xen/intr: move isrc allocation out of xen_intr_bind_isrc().Jul 30 2021, 2:28 AM

Simply exploring some of the potential effects of D31188. Alas moving other close needed instances in is rather more difficult.

Updating this in light of other patches having been updated.

Harbormaster completed remote builds in B41244: Diff 94297.Aug 27 2021, 11:20 PM

Updating to match D31188 update.

Harbormaster completed remote builds in B42602: Diff 98050.Nov 5 2021, 5:34 AM

This appears to potentially benefit from D32876 as it means there is no longer a need to use xen_intr_unbind(). There is even more potential for merging things down, but this needs to be done with care. Alas, this doesn't appear to benefit my main goal.

ehem_freebsd_m5p.com added a parent revision: D33624: xen/intr: add channel closing in case of early setup failure.Dec 23 2021, 6:27 AM

Finally figured out how to do this, D33622/D33623/D33624 are how. Some functions were using xen_intr_unbind() since they needed the handler removed before calling xen_intr_release_isrc(), D33622 addresses the issue. Then simply cleaning things up.

Harbormaster completed remote builds in B43554: Diff 100489.Dec 23 2021, 6:30 AM

ehem_freebsd_m5p.com added a reviewer: mhorne.Dec 23 2021, 6:36 AM

ehem_freebsd_m5p.com removed a parent revision: D31188: xen/intr: move isrc allocation out of xen_intr_bind_isrc().Dec 23 2021, 5:28 PM

mhorne mentioned this in D31188: xen/intr: move isrc allocation out of xen_intr_bind_isrc().Dec 27 2021, 3:59 PM

ehem_freebsd_m5p.com removed a reviewer: mhorne.Jun 28 2022, 11:33 PM

Updating to current tree status.

Harbormaster completed remote builds in B46175: Diff 107514.Jun 28 2022, 11:34 PM

Updating to present tree status. Like the others in this sequence, suddenly a distinct approach has a massive impact.

Harbormaster completed remote builds in B47797: Diff 111711.Oct 12 2022, 4:08 PM

ehem_freebsd_m5p.com edited parent revisions, added: D32866: xen/intr: merge CPU assignment during port binding together; removed: D33624: xen/intr: add channel closing in case of early setup failure.Oct 12 2022, 7:01 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

xen/

bus/

94 lines

Diff 107514

sys/dev/xen/bus/xen_intr.c

Loading...