Page MenuHomeFreeBSD
Differential D35496

if_dwc: add detach method
ClosedPublic
Actions

Authored by mhorne on Jun 15 2022, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 17, 6:34 AM
Unknown Object (File)
Oct 15 2024, 11:16 PM
Unknown Object (File)
Oct 15 2024, 2:20 PM
Unknown Object (File)
Oct 13 2024, 8:04 PM
Unknown Object (File)
Oct 12 2024, 8:23 AM
Unknown Object (File)
Oct 11 2024, 12:30 AM
Unknown Object (File)
Oct 10 2024, 12:51 AM
Unknown Object (File)
Oct 10 2024, 12:51 AM
View All 84 Files
Subscribers
imp

Details

Reviewers
manu
br
mmel
Commits
rG5dec16de37f5: if_dwc: add detach method
rG27b39e58b39e: if_dwc: add detach method
Summary

It might not be super useful at the moment, but it works.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46004
Build 42892: arc lint + arc unit

Event Timeline

mhorne created this revision.Jun 15 2022, 7:49 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 15 2022, 7:49 PM
mhorne requested review of this revision.Jun 15 2022, 7:49 PM
Harbormaster completed remote builds in B45994: Diff 106961.Jun 15 2022, 7:49 PM
mhorne added a child revision: D35497: if_dwc: consistently use if.c helper methods.Jun 15 2022, 7:49 PM
manu accepted this revision.Jun 15 2022, 8:07 PM

It is useful for testing, thanks ;)

This revision is now accepted and ready to land.Jun 15 2022, 8:07 PM
mhorne added a comment.Jun 15 2022, 8:10 PM
In D35496#805065, @manu wrote:

It is useful for testing, thanks ;)

Exactly, only I couldn't convince devctl to reattach the device :')

mmel added inline comments.Jun 16 2022, 9:07 AM
sys/dev/dwc/if_dwc.c
1755

This is slightly racy ->the interrupt should be teardown first, otherwise it may occurs in the middle
of HW deinitialization or ifc destruction.

mhorne updated this revision to Diff 106989.Jun 16 2022, 2:44 PM

Disable and tear down interrupts first in the detach method.

This revision now requires review to proceed.Jun 16 2022, 2:44 PM
Harbormaster completed remote builds in B46004: Diff 106989.Jun 16 2022, 2:44 PM
mhorne marked an inline comment as done.Jun 16 2022, 2:51 PM
mhorne added inline comments.
sys/dev/dwc/if_dwc.c
1755

Thanks. Am I right in thinking that the call to ether_ifdetach() adequately protects us from races with dwc_ioctl()?

Meaning, it should not be possible for dwc_ioctl(SIOCGIFMEDIA) to occur while we are deleting the miibus child.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 23 2022, 6:16 PM
Closed by commit rG27b39e58b39e: if_dwc: add detach method (authored by mhorne). · Explain Why
This revision was automatically updated to reflect the committed changes.
mhorne marked an inline comment as done.
mhorne added a commit: rG27b39e58b39e: if_dwc: add detach method.
mhorne added a commit: rG5dec16de37f5: if_dwc: add detach method.Jul 4 2022, 4:40 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
dwc/
88 lines

Diff 106989

View Options

sys/dev/dwc/if_dwc.c

Loading...