Page MenuHomeFreeBSD
Differential D35360

date: attempt to more accurately describe year limitations with -v
ClosedPublic
Actions

Authored by kevans on May 31 2022, 4:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 5:53 PM
Unknown Object (File)
Jan 30 2025, 2:25 AM
Unknown Object (File)
Jan 21 2025, 10:47 PM
Unknown Object (File)
Dec 2 2024, 3:18 PM
Unknown Object (File)
Nov 30 2024, 6:51 PM
Unknown Object (File)
Nov 30 2024, 11:53 AM
Unknown Object (File)
Oct 13 2024, 11:06 PM
Unknown Object (File)
Sep 28 2024, 11:00 AM
View All 63 Files
Subscribers
imp
pauamma_gundo.com

Details

Reviewers
0mp
emaste
pauamma_gundo.com
Group Reviewers
Klara
manpages
Commits
rG9fcac31db460: date: attempt to more accurately describe year limitations with -v
Summary

The previous description was both incorrect and incomplete in its
description -- the 2038 limit doesn't apply on !i386 platforms, and
it didn't note that values above 100 are accepted and interpreted
differently. Further, it didn't note that absolute years are accepted.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45889
Build 42777: arc lint + arc unit

Event Timeline

kevans created this revision.May 31 2022, 4:31 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 31 2022, 4:31 AM
kevans requested review of this revision.May 31 2022, 4:31 AM
Harbormaster completed remote builds in B45782: Diff 106495.May 31 2022, 4:31 AM
pauamma_gundo.com requested changes to this revision.May 31 2022, 5:14 AM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.
pauamma_gundo.com added inline comments.
bin/date/date.1
232

Just to confirm: other 32-bit architectures (ARM, MIPS, PowerPC) have the extended year range that I assume means time_t is 64 bits long?

233–234
235–236
237

Do you mean "in the 4-digit or longer year format"? If you do:

  • I'd move "absolute" to the second "year".
  • How does date decide whether 1905 means Gregorian year 1905 (absolute) or Gregorian year 1900 + 1905 = 3805 (relative to 1900)? Since 1905 is greater than 100, both interpretations are compatible with the language of your draft change.
This revision now requires changes to proceed.May 31 2022, 5:14 AM
kevans added inline comments.May 31 2022, 5:24 AM
bin/date/date.1
232

Correct, i386 is the only supported platform with a 32-bit time_t

237

4-digits are interpreted as a relative year up to and including the start of the tm_year, which is 1900 -- after that, it's just 'the desired year'. i.e., '1900y' is always 1900+1900, '1901y' and later are always the year specified.

pauamma_gundo.com added inline comments.May 31 2022, 9:55 AM
bin/date/date.1
235–236
237
kevans updated this revision to Diff 106708.Jun 7 2022, 1:45 AM
kevans marked 5 inline comments as done.

Address review feedback (sorry for the delay)

Harbormaster completed remote builds in B45889: Diff 106708.Jun 7 2022, 1:45 AM
pauamma_gundo.com accepted this revision.Jun 9 2022, 11:37 PM

No worry. I'm swamped anyway.

This revision is now accepted and ready to land.Jun 9 2022, 11:37 PM
Closed by commit rG9fcac31db460: date: attempt to more accurately describe year limitations with -v (authored by kevans). · Explain WhyJun 28 2022, 3:54 AM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG9fcac31db460: date: attempt to more accurately describe year limitations with -v.

Revision Contents
Changeset List

PathSize
bin/
date/
12 lines

Diff 106708

View Options

bin/date/date.1

Show All 26 Lines
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.\" @(#)date.1 8.3 (Berkeley) 4/28/95 .\" @(#)date.1 8.3 (Berkeley) 4/28/95
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd November 3, 2021 .Dd May 31, 2022
.Dt DATE 1 .Dt DATE 1
.Os .Os
.Sh NAME .Sh NAME
.Nm date .Nm date
.Nd display or set date and time .Nd display or set date and time
.Sh SYNOPSIS .Sh SYNOPSIS
.\" Display time. .\" Display time.
.Nm .Nm
▲ Show 20 Lines • Show All 178 Lines • ▼ Show 20 Lines
Flags are processed in the order given. Flags are processed in the order given.
.Pp .Pp
When setting values When setting values
(rather than adjusting them), (rather than adjusting them),
seconds are in the range 0-59, minutes are in the range 0-59, hours are seconds are in the range 0-59, minutes are in the range 0-59, hours are
in the range 0-23, month days are in the range 1-31, week days are in the in the range 0-23, month days are in the range 1-31, week days are in the
range 0-6 (Sun-Sat), range 0-6 (Sun-Sat),
months are in the range 1-12 (Jan-Dec) months are in the range 1-12 (Jan-Dec)
and years are in the range 80-38 or 1980-2038. and years are in a limited range depending on the platform.
.Pp
On i386, years are in the range 69-38 representing 1969-2038.
pauamma_gundo.comUnsubmitted
Done
Inline Actions

Just to confirm: other 32-bit architectures (ARM, MIPS, PowerPC) have the extended year range that I assume means time_t is 64 bits long?

pauamma_gundo.com: Just to confirm: other 32-bit architectures (ARM, MIPS, PowerPC) have the extended year range…
kevansAuthorUnsubmitted
Done
Inline Actions

Correct, i386 is the only supported platform with a 32-bit time_t

kevans: Correct, i386 is the only supported platform with a 32-bit time_t
On every other platform, years 0-68 are accepted and represent 2000-2068, and
69-99 are accepted and represent 1969-1999.
pauamma_gundo.comUnsubmitted
Done
Inline Actions
On i386, years are in the range 69-38 representing 1969-2038.
- On every other platform, years up to 68 are accepted to represent 2068, and
- 69-99 are accepted to represent 1969-1999.
+ On every other platform, years 0-68 are accepted and represent 2000-2068, and
+ 69-99 are accepted and represent 1969-1999.
In both cases, years 100+ are accepted and interpreted as relative to 1900 with
pauamma_gundo.com:
In both cases, years between 100 and 1900 (both included) are accepted and
interpreted as relative to 1900 of the Gregorian calendar with a limit of 138 on
pauamma_gundo.comUnsubmitted
Done
Inline Actions
69-99 are accepted to represent 1969-1999.
- In both cases, years 100+ are accepted and interpreted as relative to 1900 with
+ In both cases, years starting with 100 are accepted and interpreted as relative to 1900 of the Gregorian calendar with
a limit of 138 on i386 and a much higher limit on every other platform.
Note that absolute years starting at 1901 are also accepted in the year format.
pauamma_gundo.com:
pauamma_gundo.comUnsubmitted
Done
Inline Actions
69-99 are accepted to represent 1969-1999.
- In both cases, years 100+ are accepted and interpreted as relative to 1900 with
+ In both cases, years between 100 and 1900 (both includedà are accepted and interpreted as relative to 1900 with
a limit of 138 on i386 and a much higher limit on every other platform.
Note that absolute years starting at 1901 are also accepted in the year format.
pauamma_gundo.com:
i386 and a much higher limit on every other platform.
pauamma_gundo.comUnsubmitted
Not Done
Inline Actions

Do you mean "in the 4-digit or longer year format"? If you do:

  • I'd move "absolute" to the second "year".
  • How does date decide whether 1905 means Gregorian year 1905 (absolute) or Gregorian year 1900 + 1905 = 3805 (relative to 1900)? Since 1905 is greater than 100, both interpretations are compatible with the language of your draft change.
pauamma_gundo.com: Do you mean "in the 4-digit or longer year format"? If you do: - I'd move "absolute" to the…
kevansAuthorUnsubmitted
Done
Inline Actions

4-digits are interpreted as a relative year up to and including the start of the tm_year, which is 1900 -- after that, it's just 'the desired year'. i.e., '1900y' is always 1900+1900, '1901y' and later are always the year specified.

kevans: 4-digits are interpreted as a relative year up to and including the start of the tm_year, which…
pauamma_gundo.comUnsubmitted
Done
Inline Actions
a limit of 138 on i386 and a much higher limit on every other platform.
- Note that absolute years starting at 1901 are also accepted in the year format.
+ Years starting at 1901 are also accepted, and are interpreted as absolute years.
.Pp
If
.Ar val
pauamma_gundo.com:
Years starting at 1901 are also accepted, and are interpreted as absolute years.
.Pp .Pp
If If
.Ar val .Ar val
is numeric, one of either is numeric, one of either
.Cm y , .Cm y ,
.Cm m , .Cm m ,
.Cm w , .Cm w ,
.Cm d , .Cm d ,
▲ Show 20 Lines • Show All 342 Lines • Show Last 20 Lines