Differential D35305

libc/syslog: deprecate use of "/var/run/logpriv"
ClosedPublic
Actions

Authored by glebius on May 23 2022, 9:06 PM.

Tags

None

Referenced Files

	F86132505: D35305.diff
	Sat, Jun 15, 9:58 PM

	Unknown Object (File)
	Tue, Jun 11, 8:48 PM

	Unknown Object (File)
	Mon, Jun 10, 2:48 AM

	Unknown Object (File)
	Sun, Jun 9, 8:22 AM

	Unknown Object (File)
	Sun, Jun 9, 8:19 AM

	Unknown Object (File)
	Apr 10 2024, 9:52 PM

	Unknown Object (File)
	Apr 5 2024, 10:17 AM

	Unknown Object (File)
	Apr 5 2024, 10:17 AM

View All 43 Files

Subscribers

Details

Reviewers: None
Commits: rGddc689051917: libc/syslog: deprecate use of "/var/run/logpriv"

Summary

This additional socket was created in 2e89951b6f20 and 240d5a9b1ce76
to try workaround problems with classic AF_UNIX/SOCK_DGRAM sockets.

With recent changes in kernel this trick is no longer needed, so the
trick can be reverted.

In syslogd(8) we would still create the socket for the next several
major releases for compatibility.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45686
Build 42574: arc lint + arc unit

Event Timeline

glebius created this revision.May 23 2022, 9:06 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2022, 9:06 PM

glebius requested review of this revision.May 23 2022, 9:06 PM

Harbormaster completed remote builds in B45686: Diff 106304.May 23 2022, 9:06 PM

glebius added a parent revision: D35304: libc/syslog: fully deprecate and don't try to open "/dev/log".May 23 2022, 9:06 PM

glebius added parent revisions: D35293: unix/dgram: add a specific send method - uipc_sosend_dgram(), D35294: unix/dgram: cleanup uipc_send of PF_UNIX/SOCK_DGRAM, step 1, D35295: unix/dgram: cleanup uipc_send of PF_UNIX/SOCK_DGRAM, step 2, D35296: unix/dgram: add a specific receive method - uipc_soreceive_dgram, D35297: unix/dgram: inline sbappendaddr_locked() into uipc_sosend_dgram(), D35298: unix: provide an option to return locked from unp_connectat(), D35299: sockets: enable protocol specific socket buffers, D35300: unix/dgram: use minimal possible socket buffer for PF_UNIX/SOCK_DGRAM, D35301: m_uiotombuf: write total memory length of the allocated chain in pkthdr, D35302: unix/dgram: reduce mbuf chain traversals in send(2) and recv(2), D35303: unix/dgram: smart socket buffers for one-to-many sockets.

glebius mentioned this in D35303: unix/dgram: smart socket buffers for one-to-many sockets.May 23 2022, 9:22 PM

zlei mentioned this in D34563: devfs.rules: Do not expose "log" in the default devfs rules..May 24 2022, 2:08 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 24 2022, 4:11 PM

Closed by commit rGddc689051917: libc/syslog: deprecate use of "/var/run/logpriv" (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGddc689051917: libc/syslog: deprecate use of "/var/run/logpriv".

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

75 lines

Diff 106304

lib/libc/gen/syslog.c

Loading...