Page MenuHomeFreeBSD
Differential D34563

devfs.rules: Do not expose "log" in the default devfs rules.
ClosedPublic
Actions

Authored by zlei on Mar 15 2022, 9:27 AM.
Tags
Referenced Files
F154933824: D34563.id106317.diff
Thu, Apr 30, 4:00 AM
F154751029: D34563.id.diff
Wed, Apr 29, 9:14 AM
Unknown Object (File)
Tue, Apr 28, 8:37 PM
Unknown Object (File)
Tue, Apr 28, 1:24 PM
Unknown Object (File)
Tue, Apr 28, 6:30 AM
Unknown Object (File)
Sun, Apr 26, 4:20 AM
Unknown Object (File)
Fri, Apr 17, 9:04 PM
Unknown Object (File)
Fri, Apr 17, 7:35 AM
View All Files
Subscribers
freebsd_igalic.co
imp
markj

Details

Reviewers
hrs
jh
markj
Group Reviewers
Jails
Commits
rG4d8dd8c29480: devfs.rules: Do not expose "log" in the default devfs rules
rG2670ea8a075e: devfs.rules: Do not expose "log" in the default devfs rules.
Summary

/etc/rc.d/jail no longer creates /dev/log as a symbolic link since commit 84b354cb9ab61224713c159b1484e8f070fd37be.

PR: 228351

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Mar 15 2022, 9:27 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 15 2022, 9:27 AM
zlei requested review of this revision.Mar 15 2022, 9:27 AM
markj accepted this revision.Mar 18 2022, 6:53 PM
markj added a subscriber: markj.

Seems reasonable. I think /dev/log is legacy anyway.

This revision is now accepted and ready to land.Mar 18 2022, 6:53 PM
zlei added a comment.May 16 2022, 2:54 AM

Ping

jamie accepted this revision as: Jails.May 16 2022, 2:57 AM
zlei added a comment.May 23 2022, 6:57 AM

I do not have direct access to the repository, @markj may you please commit this?

freebsd_igalic.co added a subscriber: freebsd_igalic.co.May 23 2022, 7:19 AM
In D34563#784083, @markj wrote:

Seems reasonable. I think /dev/log is legacy anyway.

does that mean i don't have to change anything about D27411 once this gets committed?

zlei added a comment.May 24 2022, 2:08 AM
In D34563#799891, @me_igalic.co wrote:
In D34563#784083, @markj wrote:

Seems reasonable. I think /dev/log is legacy anyway.

does that mean i don't have to change anything about D27411 once this gets committed?

I think it is D35305 .

zlei added a comment.May 24 2022, 2:08 AM

See also D35304

markj added a comment.May 24 2022, 1:58 PM
In D34563#799888, @zlei.huang_gmail.com wrote:

I do not have direct access to the repository, @markj may you please commit this?

My apologies for the delay. Thanks for the patch.

Closed by commit rG2670ea8a075e: devfs.rules: Do not expose "log" in the default devfs rules. (authored by zlei, committed by markj). · Explain WhyMay 24 2022, 1:58 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG2670ea8a075e: devfs.rules: Do not expose "log" in the default devfs rules..
zlei added a comment.Jan 18 2023, 10:10 AM

I think this patch also apply to stable/12.
I'd like to MFC it to stable/12, @markj do you have any objections ?

markj added a comment.Jan 18 2023, 2:47 PM
In D34563#865612, @zlei wrote:

I think this patch also apply to stable/12.
I'd like to MFC it to stable/12, @markj do you have any objections ?

No objection from me. /dev/log was removed long enough ago that this should be fine.

zlei added a commit: rG4d8dd8c29480: devfs.rules: Do not expose "log" in the default devfs rules.Jan 19 2023, 3:07 PM

Revision Contents
Changeset List

PathSize
sbin/
devfs/
1 line

Diff 106317

View Options

sbin/devfs/devfs.rules

Loading...