Page MenuHomeFreeBSD
Differential D34829

i40e_validate_filter_settings: Remove unused variables.
ClosedPublic
Actions

Authored by jhb on Apr 7 2022, 6:02 PM.
Tags
None
Referenced Files
F111662022: D34829.id104738.diff
Thu, Mar 6, 4:38 PM
F111651562: D34829.diff
Thu, Mar 6, 1:02 PM
F111617895: D34829.id104738.diff
Thu, Mar 6, 2:06 AM
F111606057: D34829.id104923.diff
Wed, Mar 5, 10:25 PM
F111596561: D34829.id104738.diff
Wed, Mar 5, 7:10 PM
Unknown Object (File)
Thu, Feb 27, 9:10 AM
Unknown Object (File)
Thu, Feb 20, 4:45 PM
Unknown Object (File)
Sat, Feb 8, 2:43 PM
View All 52 Files
Subscribers
ae
imp

Details

Reviewers
erj
krzysztof.galazka_intel.com
Commits
rGc434b26cf3eb: i40e_validate_filter_settings: Remove unused variables.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Apr 7 2022, 6:02 PM
Herald added subscribers: ae, imp. · View Herald TranscriptApr 7 2022, 6:02 PM
jhb requested review of this revision.Apr 7 2022, 6:02 PM
Harbormaster completed remote builds in B45062: Diff 104738.Apr 7 2022, 6:02 PM
erj added a reviewer: krzysztof.galazka_intel.com.Apr 11 2022, 6:39 PM
erj requested changes to this revision.Apr 11 2022, 6:46 PM

Checking internally, it looks like those variables can just be removed. I also don't see anything similar to the GLHMC_FCOEFMAX register in the hardware for the PE filters or contexts.

This revision now requires changes to proceed.Apr 11 2022, 6:46 PM
jhb retitled this revision from ixl: Mark two variables as unused. to i40e_validate_filter_settings: Remove unused variables..Apr 12 2022, 5:21 PM
jhb edited the summary of this revision. (Show Details)
jhb updated this revision to Diff 104923.Apr 12 2022, 5:28 PM
  • Remove the variables instead of marking them as unused.
Harbormaster completed remote builds in B45128: Diff 104923.Apr 12 2022, 5:28 PM
erj accepted this revision.Apr 12 2022, 8:15 PM
This revision is now accepted and ready to land.Apr 12 2022, 8:15 PM
Closed by commit rGc434b26cf3eb: i40e_validate_filter_settings: Remove unused variables. (authored by jhb). · Explain WhyApr 12 2022, 9:53 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGc434b26cf3eb: i40e_validate_filter_settings: Remove unused variables..

Revision Contents
Changeset List

PathSize
sys/
dev/
ixl/
5 lines

Diff 104934

View Options

sys/dev/ixl/i40e_common.c

Loading...