i40e_validate_filter_settings: Remove unused variables.
ClosedPublic
Actions

Authored by jhb on Apr 7 2022, 6:02 PM.

Details

Reviewers

erj
krzysztof.galazka_intel.com

Commits

rGc434b26cf3eb: i40e_validate_filter_settings: Remove unused variables.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45128
Build 42016: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 7 2022, 6:02 PM

Herald added subscribers: ae, imp. · View Herald TranscriptApr 7 2022, 6:02 PM

jhb requested review of this revision.Apr 7 2022, 6:02 PM

Harbormaster completed remote builds in B45062: Diff 104738.Apr 7 2022, 6:02 PM

erj added a reviewer: krzysztof.galazka_intel.com.Apr 11 2022, 6:39 PM

Checking internally, it looks like those variables can just be removed. I also don't see anything similar to the GLHMC_FCOEFMAX register in the hardware for the PE filters or contexts.

This revision now requires changes to proceed.Apr 11 2022, 6:46 PM

jhb retitled this revision from ixl: Mark two variables as unused. to i40e_validate_filter_settings: Remove unused variables..Apr 12 2022, 5:21 PM

jhb edited the summary of this revision. (Show Details)

Remove the variables instead of marking them as unused.

Harbormaster completed remote builds in B45128: Diff 104923.Apr 12 2022, 5:28 PM

erj accepted this revision.Apr 12 2022, 8:15 PM

This revision is now accepted and ready to land.Apr 12 2022, 8:15 PM

Closed by commit rGc434b26cf3eb: i40e_validate_filter_settings: Remove unused variables. (authored by jhb). · Explain WhyApr 12 2022, 9:53 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGc434b26cf3eb: i40e_validate_filter_settings: Remove unused variables..

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixl/

i40e_common.c

5 lines

Diff 104923

View Options

i40e_validate_filter_settings: Remove unused variables.ClosedPublicActions