Remove checks for __GNUCLIKE macros for varargs.
ClosedPublic
Actions

Authored by jhb on Apr 6 2022, 2:26 PM.

Details

Reviewers

brooks
emaste
imp

Commits

rGb8717a8709b2: Remove checks for __GNUCLIKE macros for varargs.

Summary

All supported compilers (modern versions of GCC and clang) support
these.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 6 2022, 2:26 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 6 2022, 2:26 PM

jhb requested review of this revision.Apr 6 2022, 2:26 PM

Harbormaster completed remote builds in B45025: Diff 104666.Apr 6 2022, 2:26 PM

jhb added a parent revision: D34799: Remove checks for __GNUCLIKE___SECTION assuming it is always true..Apr 6 2022, 2:26 PM

jhb added a child revision: D34801: Remove check for __CC_SUPPORTS___FUNC__..

imp accepted this revision.Apr 6 2022, 2:34 PM

This revision is now accepted and ready to land.Apr 6 2022, 2:34 PM

jhb added inline comments.Apr 7 2022, 6:02 PM

sys/sys/_stdarg.h
44	These lines should perhaps be unindented? Maybe as a followup.

imp added inline comments.Apr 7 2022, 9:40 PM

sys/sys/_stdarg.h
44	agreed.

I can't find any instance of __NO_GNUC_VA_LIST in the world so I'd be tempted to drop it, perhaps in another commit.

Closed by commit rGb8717a8709b2: Remove checks for __GNUCLIKE macros for varargs. (authored by jhb). · Explain WhyApr 12 2022, 5:13 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGb8717a8709b2: Remove checks for __GNUCLIKE macros for varargs..

Revision Contents
Changeset List

Path

Size

sys/

_stdarg.h

2 lines

_types.h

7 lines

Diff 104918

View Options

sys/sys/_stdarg.h