as3722_gpio_pin_setflags: Use computed mode instead of hardcoded PUSHPULL.
ClosedPublic
Actions

Authored by jhb on Apr 9 2022, 1:00 AM.

Details

Reviewers

mmel
emaste

Commits

rG050b951c6719: as3722_gpio_pin_setflags: Use computed mode instead of hardcoded PUSHPULL.
rGdca7f696322a: as3722_gpio_pin_setflags: Use computed mode instead of hardcoded PUSHPULL.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45090
Build 41978: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 9 2022, 1:00 AM

Herald added subscribers: andrew, imp. · View Herald TranscriptApr 9 2022, 1:00 AM

jhb requested review of this revision.Apr 9 2022, 1:00 AM

Harbormaster completed remote builds in B45090: Diff 104799.Apr 9 2022, 1:00 AM

My guess is that this is correct? Otherwise the 'mode' variable (and as3722_gpio_get_mode() function) are unused.

Yeah, if this introduces a change in behaviour the old code was just hiding a bug.
Probably worth a longish MFC timeout and a request for someone to test.

This revision is now accepted and ready to land.Apr 18 2022, 7:20 PM

Closed by commit rGdca7f696322a: as3722_gpio_pin_setflags: Use computed mode instead of hardcoded PUSHPULL. (authored by jhb). · Explain WhyApr 18 2022, 7:31 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGdca7f696322a: as3722_gpio_pin_setflags: Use computed mode instead of hardcoded PUSHPULL..

jhb added a commit: rG050b951c6719: as3722_gpio_pin_setflags: Use computed mode instead of hardcoded PUSHPULL..May 13 2022, 10:56 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

nvidia/

as3722_gpio.c

2 lines

Diff 104799

View Options

sys/arm/nvidia/as3722_gpio.c

as3722_gpio_pin_setflags: Use computed mode instead of hardcoded PUSHPULL.ClosedPublicActions