Page MenuHomeFreeBSD

as3722_gpio_pin_setflags: Use computed mode instead of hardcoded PUSHPULL.
ClosedPublic

Authored by jhb on Apr 9 2022, 1:00 AM.
Tags
None
Referenced Files
F86847958: D34855.id104799.diff
Wed, Jun 26, 12:45 PM
Unknown Object (File)
Mon, Jun 17, 3:15 PM
Unknown Object (File)
Apr 27 2024, 9:54 AM
Unknown Object (File)
Apr 27 2024, 9:54 AM
Unknown Object (File)
Apr 27 2024, 8:36 AM
Unknown Object (File)
Apr 27 2024, 7:10 AM
Unknown Object (File)
Mar 14 2024, 3:31 AM
Unknown Object (File)
Jan 14 2024, 8:39 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45090
Build 41978: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 9 2022, 1:00 AM

My guess is that this is correct? Otherwise the 'mode' variable (and as3722_gpio_get_mode() function) are unused.

emaste added a subscriber: emaste.

Yeah, if this introduces a change in behaviour the old code was just hiding a bug.
Probably worth a longish MFC timeout and a request for someone to test.

This revision is now accepted and ready to land.Apr 18 2022, 7:20 PM