Page MenuHomeFreeBSD
Differential D34846

pf: drain Ethernet rules cleanup before starting a new transaction
ClosedPublic
Actions

Authored by kp on Apr 8 2022, 5:23 PM.
Tags
None
Referenced Files
F166792504: D34846.diff
Sun, Aug 16, 5:15 PM
Unknown Object (File)
Sat, Aug 15, 8:41 PM
Unknown Object (File)
Fri, Aug 14, 7:14 PM
Unknown Object (File)
Thu, Aug 13, 9:37 PM
Unknown Object (File)
Thu, Aug 13, 6:38 PM
Unknown Object (File)
Wed, Aug 12, 10:39 AM
Unknown Object (File)
Tue, Aug 11, 11:01 PM
Unknown Object (File)
Tue, Aug 11, 10:21 AM
View All Files
Subscribers
farrokhi
glebius
imp
melifaro
zlei

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG4496aecb56e6: pf: drain Ethernet rules cleanup before starting a new transaction
Summary

Inactive Ethernet rules get cleaned by a net_epoch callback. This
callback may still be pending when we try to start a new (pf rules)
transaction, causing it to fail.
This is especially likely to occur in scripted scenarios, such as the
regression tests.

Drain the epoch callbacks before starting a new transaction, ensuring
we've had the opportunity to clean up the inactive rules.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45080
Build 41968: arc lint + arc unit

Event Timeline

kp created this revision.Apr 8 2022, 5:23 PM
Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptApr 8 2022, 5:23 PM
kp requested review of this revision.Apr 8 2022, 5:23 PM
Harbormaster completed remote builds in B45080: Diff 104781.Apr 8 2022, 5:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2022, 3:51 PM
Closed by commit rG4496aecb56e6: pf: drain Ethernet rules cleanup before starting a new transaction (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG4496aecb56e6: pf: drain Ethernet rules cleanup before starting a new transaction.
zlei added a subscriber: zlei.Jan 11 2023, 9:52 AM

Spot this while doing local MFC into stable/13 of 150486f6a940 .
Is this fix a candidate for stable/13 ?

kp added a comment.Jan 11 2023, 8:10 PM
In D34846#863624, @zlei wrote:

Spot this while doing local MFC into stable/13 of 150486f6a940 .
Is this fix a candidate for stable/13 ?

I believe the pf ethernet code isn't present in stable/13, so I wouldn't think this needs to be MFC'd.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
2 lines

Diff 104781

View Options

sys/netpfil/pf/pf_ioctl.c

Loading...