Differential D34694

Handle non-page aligned/sized memory in physmem
ClosedPublic
Actions

Authored by andrew on Mar 28 2022, 3:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 25, 7:50 PM

	Unknown Object (File)
	Fri, Sep 25, 5:42 PM

	Unknown Object (File)
	Thu, Sep 17, 10:55 AM

	Unknown Object (File)
	Thu, Sep 17, 1:01 AM

	Unknown Object (File)
	Fri, Sep 11, 2:10 AM

	Unknown Object (File)
	Thu, Sep 10, 4:36 PM

	Unknown Object (File)
	Thu, Sep 10, 2:43 PM

	Unknown Object (File)
	Tue, Sep 8, 4:50 PM

Subscribers

Details

Reviewers

None

Group Reviewers

ARM
arm64
riscv

Commits

rGfc5ab0227bba: Handle non-page aligned/sized memory in physmem
rGd8bff5b67c9b: Handle non-page aligned/sized memory in physmem

Summary

In some configurations the firmware may pass memory regions that are
not page sized or aligned, e.g. when using 16k pages on arm64. If this
is the case we will calculate many small regions because the alignment
is applied before being inserted. As we round the start up and end down
this will leave a 1 page hole between what should have been a single
region.

Fix by keeping the original alignment until we are just about to insert
the region into the avail array.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44902
Build 41790: arc lint + arc unit

Event Timeline

andrew created this revision.Mar 28 2022, 3:05 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 28 2022, 3:05 PM

andrew requested review of this revision.Mar 28 2022, 3:05 PM

Harbormaster completed remote builds in B44902: Diff 104283.Mar 28 2022, 3:05 PM

andrew added a parent revision: D34691: Port subr_physmem to userspace and add tests.Mar 28 2022, 3:05 PM

This seems to partially obsolete D32873

Yes, I forgot about that change. The other parts of D32873 look like they should be committed.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 6 2022, 1:26 PM

Closed by commit rGd8bff5b67c9b: Handle non-page aligned/sized memory in physmem (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGd8bff5b67c9b: Handle non-page aligned/sized memory in physmem.

andrew added a commit: rGfc5ab0227bba: Handle non-page aligned/sized memory in physmem.May 3 2022, 2:05 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

17 lines

tests/

sys/

kern/

subr_physmem_test.c

22 lines

Diff 104283

sys/kern/subr_physmem.c

Loading...

tests/sys/kern/subr_physmem_test.c

Loading...