Page MenuHomeFreeBSD

devmatch: Actually ignore fields tagged as '#'
ClosedPublic

Authored by val_packett.cool on Mar 22 2022, 12:02 PM.
Tags
None
Referenced Files
F170121812: D34633.id104080.diff
Thu, Sep 3, 2:08 PM
F169984381: D34633.id.diff
Thu, Sep 3, 4:40 AM
F169964533: D34633.id104084.diff
Thu, Sep 3, 3:10 AM
Unknown Object (File)
Wed, Sep 2, 8:16 PM
Unknown Object (File)
Wed, Sep 2, 12:04 PM
Unknown Object (File)
Wed, Sep 2, 7:50 AM
Unknown Object (File)
Tue, Sep 1, 1:57 PM
Unknown Object (File)
Tue, Sep 1, 3:12 AM

Details

Summary

None of the iflib based drivers were being matched by devmatch, because
the ignore fields were not actually ignored. strcmp does compare
the null terminator, so only strcmp("I:#" + 2, "#") would actually
return 0, but e.g. strcmp("I:#;" + 2, "#") returns 1.

Fixes: 5dedd2517db3 ("devmatch: Ignore the pnp fields tagged as ignore ('#')")

Test Plan

Try devmatching on e.g. an if_igc device before and after :)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44850
Build 41738: arc lint + arc unit

Event Timeline

sbin/devmatch/devmatch.c
361

This one too?

This revision is now accepted and ready to land.Jun 27 2022, 8:37 PM

This one slipped my mind. I'll commit it today.