Page MenuHomeFreeBSD
Differential D34603

mixer: fix mandoc -Tlint errors
ClosedPublic
Actions

Authored by christos on Mar 18 2022, 1:51 PM.
Tags
Referenced Files
F81621518: D34603.id103996.diff
Fri, Apr 19, 2:58 AM
Unknown Object (File)
Fri, Apr 12, 1:19 AM
Unknown Object (File)
Fri, Apr 12, 1:18 AM
Unknown Object (File)
Thu, Apr 11, 8:39 PM
Unknown Object (File)
Thu, Apr 11, 7:39 PM
Unknown Object (File)
Wed, Apr 10, 6:31 AM
Unknown Object (File)
Tue, Apr 9, 7:49 PM
Unknown Object (File)
Sun, Mar 31, 12:22 PM
View All 65 Files
Subscribers
imp

Details

Reviewers
• hselasky
gbe
0mp
Commits
rGbde84602722e: mixer.4 and mixer.8: Fix mandoc -Tlint errors.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

christos created this revision.Mar 18 2022, 1:51 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 18 2022, 1:51 PM
christos requested review of this revision.Mar 18 2022, 1:51 PM
christos added a reviewer: 0mp.Mar 18 2022, 1:54 PM
0mp requested changes to this revision.Mar 18 2022, 2:28 PM

Your changes to mixer.8 seem to revert recent patches. Please submit a rebased patch.

lib/libmixer/mixer.3
166
This revision now requires changes to proceed.Mar 18 2022, 2:28 PM
christos updated this revision to Diff 103995.Mar 18 2022, 2:44 PM

Fixed.

christos marked an inline comment as done.Mar 18 2022, 2:49 PM
0mp requested changes to this revision.Mar 18 2022, 2:52 PM

Could you also run igor mixer.3? You can find igor in the package repo.

BTW, regarding mixer.8, it looks like there are no content changes, just shuffling newlines around. This is unnecessary.

This revision now requires changes to proceed.Mar 18 2022, 2:52 PM
christos updated this revision to Diff 103996.EditedMar 18 2022, 2:56 PM

Ran igor(1) on both mixer.8 and mixer.3. The line changes were made because mandoc -Tlint was printing warnings, so I wanted them to go away. :-)

• hselasky accepted this revision.Mar 20 2022, 4:17 PM
• hselasky added a comment.Mar 20 2022, 4:31 PM

Can you add a section here about the new shorthand syntax while at it?

christos added a comment.Mar 20 2022, 4:32 PM

Yes.

christos added a child revision: D34614: mixer.8: document shorthand syntax for volume setting.Mar 20 2022, 5:16 PM

Documented the new shorthand syntax in D34614. Depends on this revision.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 20 2022, 7:22 PM
Closed by commit rGbde84602722e: mixer.4 and mixer.8: Fix mandoc -Tlint errors. (authored by • hselasky). · Explain Why
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rGbde84602722e: mixer.4 and mixer.8: Fix mandoc -Tlint errors..

Revision Contents
Changeset List

PathSize
lib/
libmixer/
161 lines
usr.sbin/
mixer/
11 lines

Diff 103996

View Options

lib/libmixer/mixer.3

Loading...
View Options

usr.sbin/mixer/mixer.8

Loading...