fix 10-STABLE build on 11-CURRENT after mklocale and colldef removal
ClosedPublic
Actions

Authored by op on Nov 20 2015, 8:42 PM.

Details

Reviewers

glebius
bapt
bdrewery

Summary

On a recently upgraded build server (today's 11-CURRENT) and when someone
try to build 10-STABLE will get the following error:

> gnu/lib/libgcc (all)

sh: colldef: not found

bg_BG.CP1251.out ---
[bg_BG.CP1251.out] Error code 127

make[4]: stopped in
/usr/data/release/scratch/hardenedbsd-10-stable-20151120-1/usr/src/share/colldef
1 error

To fix this issue add colldef and mklocale to bootstrap utils when building on 11-CURRENT (1100086<).

Obtained from: HardenedBSD

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

op updated this revision to Diff 10385.Nov 20 2015, 8:42 PM

op retitled this revision from to fix 10-STABLE build on 11-CURRENT after recent locales changes.

op updated this object.

op edited the test plan for this revision. (Show Details)

op added reviewers: bapt, bdrewery.

op set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added subscribers: emaste, imp. · View Herald TranscriptNov 20 2015, 8:42 PM

my opinion is I should bring back both colldef and mklocale it does not hurt to have those tools around unused, mark them as deprecated and remove them once 9 and 10 are EOL

done it would still nice to have colldef and mklocale being build tools for stable and 10.3 so when 9, 10.1 and 10.2 are EOL we can remove those tools from head

Yes. We (HardenedBSD) already have this patch and working fine: https://github.com/HardenedBSD/hardenedBSD-stable/commit/1f4dbf94d059b9fd43944f73c890c94bedfbe6de

Is there any chance to get this patch into 10.3? As you have said, it would be nice to remove these programs from 11-CURRENT.

op retitled this revision from fix 10-STABLE build on 11-CURRENT after recent locales changes to fix 10-STABLE build on 11-CURRENT after mklocale and colldef removal .Jan 15 2016, 5:32 PM

op edited edge metadata.

I do think we should commit this to stable/10, despite being against the normal. It will prevent us having another situation of not being able to build the old release like we had with makeinfo, if we again remove mklocale from head.

imp added inline comments.Jan 17 2016, 11:52 PM