Allow callers of vm_get_name() to retrieve the vm name without having to
allocate a buffer.
Details
Details
- Reviewers
jhb - Group Reviewers
bhyve - Commits
- rG51b1d348203d: libvmm: constify vm_get_name()
rG3efc45f34e13: libvmm: constify vm_get_name()
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 44598 Build 41486: arc lint + arc unit
Event Timeline
| lib/libvmmapi/vmmapi.c | ||
|---|---|---|
| 499–500 | Note that you could just change this function and still leave 'ctx->name' as char * so you don't have to change around the code around the strcpy in vm_open. | |
| usr.sbin/bhyve/snapshot.c | ||
| 1129 | I would maybe just axe the vmname_buf variable entirely (it's a bit odd now as it's a pointer rather than a buffer) and just inline the function call here. | |
| 1520–1521 | Similarly. | |
| usr.sbin/bhyvectl/bhyvectl.c | ||
| 1690–1691 | It seems a bit odd that this even takes the ctx as an arg btw rather than just passing through the string from the --vm argument directly? | |