Page MenuHomeFreeBSD
Differential D34318

LinuxKPI: add of_node to struct device
AbandonedPublic
Actions

Authored by bz on Feb 19 2022, 1:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 4:51 PM
Unknown Object (File)
Feb 20 2025, 10:17 PM
Unknown Object (File)
Feb 5 2025, 12:42 PM
Unknown Object (File)
Feb 5 2025, 12:27 AM
Unknown Object (File)
Feb 1 2025, 9:45 PM
Unknown Object (File)
Jan 27 2025, 1:17 AM
Unknown Object (File)
Jan 18 2025, 9:33 PM
Unknown Object (File)
Jan 17 2025, 4:17 PM
View All 37 Files
Subscribers
emaste
• hselasky
manu
wulf

Details

Reviewers
imp
Group Reviewers
linuxkpi
Summary

Add the 'struct device_node *of_node' to struct device without
implementing it yet.

The main reason is to be merged to stable/13 before 13.1-R in order
for it to be used at a later time without changing struct device
right away again after the release (given it was already modified
on stable/13).

MFC after: 3 days

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44505
Build 41393: arc lint + arc unit

Event Timeline

bz created this revision.Feb 19 2022, 1:10 AM
Herald added a subscriber: emaste. · View Herald TranscriptFeb 19 2022, 1:10 AM
bz requested review of this revision.Feb 19 2022, 1:10 AM
Harbormaster completed remote builds in B44505: Diff 102962.Feb 19 2022, 1:10 AM
manu added a subscriber: manu.Feb 19 2022, 9:04 AM

Why ?
It really doesn't make sense to me to add every member to every struct that linux uses just to satisfy compilation.

• hselasky added a subscriber: • hselasky.Feb 19 2022, 9:43 AM

For Linux webcamd I usually stub it. Will this be fully implemented for ARM64 I presume?

manu added a comment.Feb 19 2022, 10:03 AM
In D34318#777015, @hselasky wrote:

For Linux webcamd I usually stub it. Will this be fully implemented for ARM64 I presume?

That would be crazy.

bz updated this revision to Diff 102967.Feb 19 2022, 11:44 AM

Add stub implementations as well.

Harbormaster completed remote builds in B44510: Diff 102967.Feb 19 2022, 11:44 AM
bz added a comment.Feb 19 2022, 11:45 AM
In D34318#777013, @manu wrote:

Why ?
It really doesn't make sense to me to add every member to every struct that linux uses just to satisfy compilation.

Because it's a lot easier to add the error returning stubs then to #ifdef out the drivers and maintain that over time.

manu added a comment.Feb 19 2022, 12:00 PM
In D34318#777059, @bz wrote:
In D34318#777013, @manu wrote:

Why ?
It really doesn't make sense to me to add every member to every struct that linux uses just to satisfy compilation.

Because it's a lot easier to add the error returning stubs then to #ifdef out the drivers and maintain that over time.

I've been maintaining drm-kmod from quite some time now and for me it's better to ifdef out in the code. It also shows that we have no intention of implementing this.

bz added a comment.Feb 19 2022, 1:32 PM
In D34318#777064, @manu wrote:
In D34318#777059, @bz wrote:
In D34318#777013, @manu wrote:

Why ?
It really doesn't make sense to me to add every member to every struct that linux uses just to satisfy compilation.

Because it's a lot easier to add the error returning stubs then to #ifdef out the drivers and maintain that over time.

I've been maintaining drm-kmod from quite some time now and for me it's better to ifdef out in the code. It also shows that we have no intention of implementing this.

Did you add the CONFIG_OF around the drm code or was it there?

I have more instances of this in a single file than I can find in the entire drm-kmod code and given the KConfig of my drivers doesn't even depend on CONFIG_OF I assume Linux must have dummy fallbacks as well as otherwise these drivers wouldn't compile in Linux for non OF kernels.

So your suggestion is to deal with these three drivers which need the pointer and completely #ifdef all the calls out and then if actually needed add native FreeBSD code and then maintain that rather that add a pointer and dummy calls? So double the work with each driver and the other ones to come? Right. Happy weekend.

bz abandoned this revision.Feb 19 2022, 1:32 PM
bz mentioned this in rGab55b58b5c51: LinuxKPI: add dummy of.h.Jun 11 2023, 10:17 PM
bz mentioned this in D42798: LinuxKPI: Add some header pollution and dummy headers.Dec 8 2023, 4:45 PM
wulf added a subscriber: wulf.Dec 11 2023, 11:18 AM

IMO things we want to have in future should be #ifdef-ed in driver rather than dummy-implemented in LKPI
But in that case we can define opaque struct device_node; in linux/of.h to satisfy struct device_node *of_node; member of struct class and than add dummy implementation somewhere in wifi driver to get rid of extra #ifdef-s

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
2 lines

Diff 102962

View Options

sys/compat/linuxkpi/common/include/linux/device.h

Show First 20 Lines • Show All 328 Lines • ▼ Show 20 Lines case 2: /* MM */
badformat(); badformat();
break; break;
default: default:
badformat(); badformat();
} }
} }
/* convert broken-down time to GMT clock time */ /* convert broken-down time to GMT clock time */
if ((ts->tv_sec = mktime(lt)) == -1) lt->tm_yday = -1;
ts->tv_sec = mktime(lt);
if (lt->tm_yday == -1)
errx(1, "nonexistent time"); errx(1, "nonexistent time");
ts->tv_nsec = 0; ts->tv_nsec = 0;
if (!jflag) { if (!jflag) {
utx.ut_type = OLD_TIME; utx.ut_type = OLD_TIME;
memset(utx.ut_id, 0, sizeof(utx.ut_id)); memset(utx.ut_id, 0, sizeof(utx.ut_id));
(void)gettimeofday(&utx.ut_tv, NULL); (void)gettimeofday(&utx.ut_tv, NULL);
pututxline(&utx); pututxline(&utx);
▲ Show 20 Lines • Show All 119 Lines • Show Last 20 Lines