The type of the kern.maxphys sysctl OID is now ulong. Change the
local variable type to match.
NetBSD has an ATF test for newfs_msdos. Connect it to the build.
Adapt it for FreeBSD. This would have caught this bug.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sbin/newfs_msdos/mkfs_msdos.c | ||
|---|---|---|
| 845 | This file will be a separate commit. | |
Comment Actions
LGTM
I think the way we handle contrib NetBSD tests is strange but that's beyond the scope of this change
Comment Actions
This could also be handled in the Makefile to avoid having to dance around FreeBSD vs NetBSD in the test, since I assume we'll never upstream the utility name item and will always deviate from NetBSD.
Examples in use:
bin/expr/tests/Makefile:ATF_TESTS_SH_SED_expr_test+= -e 's/eval expr/eval expr --/g' bin/expr/tests/Makefile:ATF_TESTS_SH_SED_expr_test+= -e 's/"expr: integer overflow or underflow occurred for operation.*"/"expr: overflow"/g' usr.bin/diff/tests/Makefile:ATF_TESTS_SH_SED_netbsd_diff_test+= -e 's/t_diff/`basename $$0`/g' usr.bin/sed/tests/Makefile:ATF_TESTS_SH_SED_sed_test+= -e 's,atf_expect_fail "PR bin/28126",,g'
Comment Actions
Please no, we used to have lots of cases of applying patches at build time etc. and it results in obfuscation and awkwardness. It made some sense in the CVS days when there was a cost to bringing a file off the vendor branch but we're much better served by using contemporary source management tools to manage it for us.