Paths

Table of Contentst

tty_info: Avoid warning by using logical instead of bitwise operators
ClosedPublic
Actions

Authored by dim on Feb 6 2022, 5:45 PM.

Details

Reviewers

cem
emaste
kevans
markj

Commits

rG534f4e03ab3c: tty_info: Avoid warning by using logical instead of bitwise operators
rGae76550171b9: tty_info: Avoid warning by using logical instead of bitwise operators
rG7d8a4eb943a9: tty_info: Avoid warning by using logical instead of bitwise operators

Summary

Since TD_IS_RUNNING() and TS_ON_RUNQ() are defined as logical
expressions involving '==', clang 14 warns about them being checked with
a bitwise operator instead of a logical one:

sys/kern/tty_info.c:124:9: error: use of bitwise '|' with boolean operands [-Werror,-Wbitwise-instead-of-logical]
        runa = TD_IS_RUNNING(td) | TD_ON_RUNQ(td);
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                 ||
sys/sys/proc.h:562:27: note: expanded from macro 'TD_IS_RUNNING'
                                ^
sys/kern/tty_info.c:124:9: note: cast one or both operands to int to silence this warning
sys/sys/proc.h:562:27: note: expanded from macro 'TD_IS_RUNNING'
                                ^
sys/kern/tty_info.c:129:9: error: use of bitwise '|' with boolean operands [-Werror,-Wbitwise-instead-of-logical]
        runb = TD_IS_RUNNING(td2) | TD_ON_RUNQ(td2);
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                  ||
sys/sys/proc.h:562:27: note: expanded from macro 'TD_IS_RUNNING'
                                ^
sys/kern/tty_info.c:129:9: note: cast one or both operands to int to silence this warning
sys/sys/proc.h:562:27: note: expanded from macro 'TD_IS_RUNNING'
                                ^

Fix this by using logical operators instead. No functional change
intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dim created this revision.Feb 6 2022, 5:45 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 6 2022, 5:45 PM

dim requested review of this revision.Feb 6 2022, 5:45 PM

Harbormaster completed remote builds in B44309: Diff 102433.Feb 6 2022, 5:45 PM

dim edited the summary of this revision. (Show Details)Feb 6 2022, 5:45 PM

markj accepted this revision.Feb 6 2022, 6:00 PM

This revision is now accepted and ready to land.Feb 6 2022, 6:00 PM

emaste accepted this revision.Feb 6 2022, 6:08 PM

Looks like TESTAB expects boolean (0 and 1) values, too.

kevans accepted this revision.Feb 6 2022, 6:14 PM

In D34186#773402, @cem wrote:

Looks like TESTAB expects boolean (0 and 1) values, too.

Well, the interesting thing is that this macro produces values 0 through 4, and it's a sort of weird shortcut to make the switch(TESTAB()) construct possible.

Strictly speaking you should do something ugly like:

#define TESTAB(a, b)    (((a)?1:0)<<1 | ((b)?1:0))

In D34186#773413, @dim wrote:

In D34186#773402, @cem wrote:

Looks like TESTAB expects boolean (0 and 1) values, too.

Well, the interesting thing is that this macro produces values 0 through 4, and it's a sort of weird shortcut to make the switch(TESTAB()) construct possible.

0-3. Yeah, it's a little weird.

Strictly speaking you should do something ugly like:
#define TESTAB(a, b)    (((a)?1:0)<<1 | ((b)?1:0))

Yeah, if a and b are not always going to be the result of boolean expressions. Here, they are.

Closed by commit rG7d8a4eb943a9: tty_info: Avoid warning by using logical instead of bitwise operators (authored by dim). · Explain WhyFeb 8 2022, 8:24 PM

This revision was automatically updated to reflect the committed changes.

dim added a commit: rG7d8a4eb943a9: tty_info: Avoid warning by using logical instead of bitwise operators.

dim added a commit: rGae76550171b9: tty_info: Avoid warning by using logical instead of bitwise operators.Feb 11 2022, 4:52 PM

dim added a commit: rG534f4e03ab3c: tty_info: Avoid warning by using logical instead of bitwise operators.

Revision Contents
Changeset List

Path

Size

sys/

kern/

tty_info.c

4 lines

Diff 102512

View Options

tty_info: Avoid warning by using logical instead of bitwise operatorsClosedPublicActions