dma: exit if invoked with invalid (zero) argc
ClosedPublic
Actions

Authored by emaste on Jan 28 2022, 10:17 PM.

Details

Reviewers

markj
kevans

Commits

rGeb32eb2b453d: dma: exit if invoked with invalid (zero) argc
rG647d3bf17cd9: dma: exit if invoked with invalid (zero) argc
rG1c91aedf25bc: dma: exit if invoked with invalid (zero) argc

Summary

Prompted by the recent pkexec vulnerability exit with an error if invoked with argc == 0.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jan 28 2022, 10:17 PM

emaste created this revision.

Apparently basename(NULL) returns ".", I didn't know that.

This revision is now accepted and ready to land.Jan 28 2022, 10:24 PM

As a general principle, I think it's still a good idea to audit base stuff for argc == 0 issues. We have downstreams for userland-only stuff, so it'd generally be more for their benefit assuming they may not pick up the kernel change (either because they can't for conformance reasons, or whatever).