Page MenuHomeFreeBSD

dma: exit if invoked with invalid (zero) argc
ClosedPublic

Authored by emaste on Jan 28 2022, 10:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 2, 8:11 PM
Unknown Object (File)
Jul 13 2025, 1:57 AM
Unknown Object (File)
Jul 11 2025, 8:55 AM
Unknown Object (File)
Jul 10 2025, 12:37 PM
Unknown Object (File)
Jul 9 2025, 9:43 PM
Unknown Object (File)
Jun 30 2025, 2:31 PM
Unknown Object (File)
Jun 28 2025, 12:06 AM
Unknown Object (File)
Jun 8 2025, 2:09 PM
Subscribers

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.

Apparently basename(NULL) returns ".", I didn't know that.

This revision is now accepted and ready to land.Jan 28 2022, 10:24 PM

As a general principle, I think it's still a good idea to audit base stuff for argc == 0 issues. We have downstreams for userland-only stuff, so it'd generally be more for their benefit assuming they may not pick up the kernel change (either because they can't for conformance reasons, or whatever).

Apparently basename(NULL) returns ".", I didn't know that.

That's... really odd.