Page MenuHomeFreeBSD

dma: exit if invoked with invalid (zero) argc
ClosedPublic

Authored by emaste on Jan 28 2022, 10:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 15 2024, 4:42 PM
Unknown Object (File)
Jan 15 2024, 12:35 AM
Unknown Object (File)
Jan 9 2024, 2:43 PM
Unknown Object (File)
Dec 27 2023, 2:41 PM
Unknown Object (File)
Dec 22 2023, 9:46 PM
Unknown Object (File)
Oct 29 2023, 7:22 PM
Unknown Object (File)
Oct 29 2023, 7:22 PM
Unknown Object (File)
Oct 28 2023, 4:44 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.

Apparently basename(NULL) returns ".", I didn't know that.

This revision is now accepted and ready to land.Jan 28 2022, 10:24 PM

As a general principle, I think it's still a good idea to audit base stuff for argc == 0 issues. We have downstreams for userland-only stuff, so it'd generally be more for their benefit assuming they may not pick up the kernel change (either because they can't for conformance reasons, or whatever).

Apparently basename(NULL) returns ".", I didn't know that.

That's... really odd.