Page MenuHomeFreeBSD

dma: exit if invoked with invalid (zero) argc
ClosedPublic

Authored by emaste on Jan 28 2022, 10:17 PM.
Tags
None
Referenced Files
F137953950: D34087.diff
Thu, Nov 27, 3:52 PM
Unknown Object (File)
Tue, Nov 25, 11:48 PM
Unknown Object (File)
Sat, Nov 15, 12:11 AM
Unknown Object (File)
Tue, Nov 11, 3:55 AM
Unknown Object (File)
Mon, Nov 3, 8:33 PM
Unknown Object (File)
Mon, Nov 3, 8:33 PM
Unknown Object (File)
Mon, Nov 3, 8:32 PM
Unknown Object (File)
Mon, Nov 3, 8:31 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.

Apparently basename(NULL) returns ".", I didn't know that.

This revision is now accepted and ready to land.Jan 28 2022, 10:24 PM

As a general principle, I think it's still a good idea to audit base stuff for argc == 0 issues. We have downstreams for userland-only stuff, so it'd generally be more for their benefit assuming they may not pick up the kernel change (either because they can't for conformance reasons, or whatever).

Apparently basename(NULL) returns ".", I didn't know that.

That's... really odd.