Page MenuHomeFreeBSD
Differential D33882

ia32: Sync signal context type names with i386.
ClosedPublic
Actions

Authored by jhb on Jan 13 2022, 9:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 22, 10:01 AM
Unknown Object (File)
Tue, Jul 21, 7:49 AM
Unknown Object (File)
Fri, Jul 10, 4:25 PM
Unknown Object (File)
Tue, Jul 7, 10:41 PM
Unknown Object (File)
Fri, Jul 3, 8:25 AM
Unknown Object (File)
Mon, Jun 29, 10:27 PM
Unknown Object (File)
Jun 27 2026, 7:26 PM
Unknown Object (File)
Jun 24 2026, 7:02 AM
View All Files
Subscribers
imp

Details

Reviewers
brooks
kib
imp
Commits
rGbd7630ef6198: ia32: Sync signal context type names with i386.
Summary
  • Use ia32_freebsd4_* instead of ia32_*4.
  • Use ia32_o* instead of ia32_*3.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43909
Build 40797: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 13 2022, 9:08 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 13 2022, 9:08 PM
jhb requested review of this revision.Jan 13 2022, 9:08 PM
Harbormaster completed remote builds in B43909: Diff 101425.Jan 13 2022, 9:08 PM
jhb added a parent revision: D33881: Rename struct sigframe4 to struct freebsd4_sigframe..Jan 13 2022, 9:08 PM
kib accepted this revision.Jan 13 2022, 9:29 PM
kib added inline comments.
sys/compat/ia32/ia32_signal.h
91

I suspect these ifdefs in the header can be removed.

This revision is now accepted and ready to land.Jan 13 2022, 9:29 PM
imp accepted this revision.Jan 13 2022, 9:50 PM
imp added inline comments.
sys/amd64/ia32/ia32_signal.c
366

Why osigframe? Is there a reason for that naming convetion?

brooks added a comment.Jan 13 2022, 10:09 PM

I think this is right.

@imp COMPAT_43 syscalls get named o<syscall> so this follows that convention. The "3" suffix is weird.

brooks accepted this revision.Jan 13 2022, 10:09 PM
jhb added a child revision: D33886: Move struct freebsd4_ucontext to sys/i386/include/ucontext.h..Jan 13 2022, 10:52 PM
jhb added inline comments.
sys/amd64/ia32/ia32_signal.c
366

Because the rest of things for COMPAT_43 use the 'o' prefix including syscalls, etc. These aren't FreeBSD 3.x things, but BSD43, so the 3 suffix is weird.

Closed by commit rGbd7630ef6198: ia32: Sync signal context type names with i386. (authored by jhb). · Explain WhyJan 14 2022, 1:18 AM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGbd7630ef6198: ia32: Sync signal context type names with i386..

Revision Contents
Changeset List

PathSize
sys/
amd64/
ia32/
18 lines
compat/
ia32/
12 lines
18 lines
6 lines

Diff 101425

View Options

sys/amd64/ia32/ia32_signal.c

Loading...
View Options

sys/compat/ia32/ia32_genassym.c

Loading...
View Options

sys/compat/ia32/ia32_signal.h

Loading...
View Options

sys/compat/ia32/ia32_sysvec.c

Loading...