Page MenuHomeFreeBSD

ia32: Sync signal context type names with i386.
ClosedPublic

Authored by jhb on Jan 13 2022, 9:08 PM.

Details

Summary
  • Use ia32_freebsd4_* instead of ia32_*4.
  • Use ia32_o* instead of ia32_*3.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Jan 13 2022, 9:08 PM
kib added inline comments.
sys/compat/ia32/ia32_signal.h
91

I suspect these ifdefs in the header can be removed.

This revision is now accepted and ready to land.Jan 13 2022, 9:29 PM
imp added inline comments.
sys/amd64/ia32/ia32_signal.c
366

Why osigframe? Is there a reason for that naming convetion?

I think this is right.

@imp COMPAT_43 syscalls get named o<syscall> so this follows that convention. The "3" suffix is weird.

jhb added inline comments.
sys/amd64/ia32/ia32_signal.c
366

Because the rest of things for COMPAT_43 use the 'o' prefix including syscalls, etc. These aren't FreeBSD 3.x things, but BSD43, so the 3 suffix is weird.

This revision was automatically updated to reflect the committed changes.