Page MenuHomeFreeBSD
Differential D33811

vm_pageout: Group sysctl variables together with sysctl definitions
ClosedPublic
Actions

Authored by markj on Jan 10 2022, 4:57 PM.
Tags
None
Referenced Files
F163296445: D33811.diff
Tue, Jul 21, 7:58 PM
Unknown Object (File)
Tue, Jul 21, 2:18 AM
Unknown Object (File)
Thu, Jul 16, 4:33 AM
Unknown Object (File)
Mon, Jul 6, 4:28 AM
Unknown Object (File)
Sun, Jul 5, 3:58 PM
Unknown Object (File)
Sun, Jul 5, 2:50 PM
Unknown Object (File)
Sat, Jul 4, 7:33 AM
Unknown Object (File)
Sat, Jul 4, 7:19 AM
View All Files
Subscribers
imp

Details

Reviewers
alc
kib
Commits
rGc4a25e071326: vm_pageout: Group sysctl variables together with sysctl definitions
Summary

Fix some style bugs while here. No functional change intended.

MFC after: 1 week

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43816
Build 40704: arc lint + arc unit

Event Timeline

markj created this revision.Jan 10 2022, 4:57 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 10 2022, 4:57 PM
markj requested review of this revision.Jan 10 2022, 4:57 PM
Harbormaster completed remote builds in B43813: Diff 101210.Jan 10 2022, 4:57 PM
markj added a parent revision: D33810: vm_pageout: Print a more accurate message to the console before an OOM kill.Jan 10 2022, 4:57 PM
kib accepted this revision.Jan 10 2022, 5:10 PM
kib added inline comments.
sys/vm/vm_pageout.c
181–182

Move the description to the new line there as well?

200–201

and there?

This revision is now accepted and ready to land.Jan 10 2022, 5:10 PM
markj updated this revision to Diff 101213.Jan 10 2022, 5:15 PM
markj marked 2 inline comments as done.
  • Put descriptions on their own lines.
  • Make whitespace consistent for all sysctls.
This revision now requires review to proceed.Jan 10 2022, 5:15 PM
Harbormaster completed remote builds in B43816: Diff 101213.Jan 10 2022, 5:15 PM
alc accepted this revision.Jan 11 2022, 12:26 AM
This revision is now accepted and ready to land.Jan 11 2022, 12:26 AM
Closed by commit rGc4a25e071326: vm_pageout: Group sysctl variables together with sysctl definitions (authored by markj). · Explain WhyJan 11 2022, 2:29 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGc4a25e071326: vm_pageout: Group sysctl variables together with sysctl definitions.

Revision Contents
Changeset List

PathSize
sys/
vm/
37 lines

Diff 101213

View Options

sys/vm/vm_pageout.c

Loading...