nvmecontrol: logpage will use the controller's vid to choose the formatting function when the vendor name is not provided.
Changes PlannedPublic
Actions

Authored by wanpengqian_gmail.com on Jan 7 2022, 1:58 AM.

Details

Reviewers

Group Reviewers

Summary

When displaying a vendor specified logpage, currently we have to specify the vendor name. if the user did not provide the vendor name, we can use the controller's vid to choose the formatting function.

Signed-off-by: Wanpeng Qian <wanpengqian@gmail.com>

Test Plan

query vendor specify logpage without specify vendor name, check the display output.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43753
Build 40641: arc lint + arc unit

Event Timeline

wanpengqian_gmail.com created this revision.Jan 7 2022, 1:58 AM

Herald added a subscriber: dab. · View Herald TranscriptJan 7 2022, 1:58 AM

wanpengqian_gmail.com requested review of this revision.Jan 7 2022, 1:58 AM

Harbormaster completed remote builds in B43753: Diff 101076.Jan 7 2022, 1:58 AM

A more proper approach would be to provide the vendor id when registering a logpage.
later it can be used to match the controller's id.

Harbormaster completed remote builds in B43756: Diff 101079.Jan 7 2022, 4:54 AM

wanpengqian_gmail.com edited the summary of this revision. (Show Details)Jan 7 2022, 4:55 AM

update print function for logpage vendor help. also update man page.

Herald added a reviewer: manpages. · View Herald TranscriptJan 7 2022, 5:37 AM

Harbormaster completed remote builds in B43761: Diff 101084.Jan 7 2022, 5:37 AM

Beside that, the manual page change LGTM.

sbin/nvmecontrol/nvmecontrol.8
249 ↗	(On Diff #101084)	By "match", do you mean "select" or "choose"? If so, I would use either of those instead for clarity.

fix a word in man page.

Harbormaster completed remote builds in B43822: Diff 101246.Jan 11 2022, 12:38 AM

wanpengqian_gmail.com added inline comments.Jan 11 2022, 12:40 AM

sbin/nvmecontrol/nvmecontrol.8
249 ↗	(On Diff #101084)	It means "choose". I have updated the man page.

wanpengqian_gmail.com edited the summary of this revision. (Show Details)Jan 11 2022, 12:43 AM

Manual page change LGTM now. Can't speak about the rest.

wanpengqian_gmail.com retitled this revision from nvmecontrol: lookup vendor name based on vendor id when formating logpage to nvmecontrol: logpage will use the controller's vid to choose the formatting function when the vendor name is not provided..Jan 11 2022, 4:09 AM

wanpengqian_gmail.com planned changes to this revision.Aug 26 2022, 12:07 AM

rpokala added a subscriber: rpokala.Aug 26 2022, 2:54 AM

rpokala added inline comments.