Page MenuHomeFreeBSD

bhyve: Map the right BAR in init_msix_table()
ClosedPublic

Authored by markj on Jan 4 2022, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 19, 2:01 AM
Unknown Object (File)
Sun, Oct 19, 1:25 AM
Unknown Object (File)
Sun, Oct 19, 12:25 AM
Unknown Object (File)
Fri, Oct 17, 6:44 AM
Unknown Object (File)
Sun, Oct 12, 9:41 AM
Unknown Object (File)
Sat, Oct 4, 7:23 AM
Unknown Object (File)
Thu, Sep 25, 5:14 PM
Unknown Object (File)
Thu, Sep 25, 4:18 PM
Subscribers

Details

Summary

The PBA and MSI-X table can reside in different BARs.

Reported by: Andy Fiddaman <andy@omniosce.org>
Fixes: 7fa233534736 ("bhyve: Map the MSI-X table unconditionally for passthrough")
MFC after: 3 days

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43709
Build 40597: arc lint + arc unit

Event Timeline

markj requested review of this revision.Jan 4 2022, 7:11 PM

Fix a second bug, also reported by Andy:

If the last page containing the table is not also the last page
of the BAR, then we would call mprotect(PROT_NONE) on the wrong
portion of the mapping.

This revision is now accepted and ready to land.Jan 4 2022, 10:35 PM