Page MenuHomeFreeBSD
Differential D4120

ARM: Fix dma_dcache_sync()
ClosedPublic
Actions

Authored by mmel on Nov 10 2015, 12:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 11:55 PM
Unknown Object (File)
Fri, Dec 20, 8:55 PM
Unknown Object (File)
Sun, Dec 1, 5:22 PM
Unknown Object (File)
Nov 29 2024, 10:33 PM
Unknown Object (File)
Nov 14 2024, 8:18 AM
Unknown Object (File)
Oct 10 2024, 1:13 AM
Unknown Object (File)
Oct 10 2024, 1:12 AM
Unknown Object (File)
Oct 10 2024, 1:12 AM
View All 97 Files
Subscribers
andrew
imp
mmoll
ARM

Details

Reviewers
kib
jah
• ian
Commits
rS291018: ARM: Fix dma_dcache_sync() for early allocated memory.
Summary

Drivers can request DMA to buffers that are not in memory represented in the vm page arrays. Because of this, store KVA of already mapped buffer to synclist and use it in dma_dcache_sync().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mmel updated this revision to Diff 10086.Nov 10 2015, 12:53 PM
mmel retitled this revision from to ARM: Fix dma_dcache_sync().
mmel updated this object.
mmel edited the test plan for this revision. (Show Details)
mmel added reviewers: jah, • ian, kib.
mmel set the repository for this revision to rS FreeBSD src repository - subversion.
mmel added a subscriber: ARM.
Herald added subscribers: andrew, imp. · View Herald TranscriptNov 10 2015, 12:53 PM
jah added inline comments.Nov 14 2015, 8:38 AM
sys/arm/arm/busdma_machdep-v6.c
1127–1138

Since you're storing the paddr in the sl alongside pages, why not always assign paddr to curaddr in sync_phys() and sync_buf()? Then you could always use paddr as the starting address for cache maintenance, and you won't need this function.

mmoll added a subscriber: mmoll.Nov 17 2015, 9:39 PM

I can at least confirm that this patch fixes the following problem on a Banana Pi Pro

Fatal kernel mode data abort: 'Translation Fault (L1)' on read
trapframe: 0xc0913ae8
FSR=00000005, FAR=00000020, spsr=20000013
r0 =c3ad3c48, r1 =c3ad3c38, r2 =00000001, r3 =00000001
r4 =00000cc0, r5 =00000000, r6 =c3b1fc00, r7 =00000000
r8 =00000040, r9 =c3ad3c00, r10=c0858c2c, r11=c0913ba8
r12=c3b31000, ssp=c0913b78, slr=c07418e8, pc =c0715f90

[ thread pid 0 tid 100000 ]
Stopped at      _bus_dmamap_sync+0x280: ldr     r0, [r5, #0x020]
mmel updated this revision to Diff 10292.Nov 18 2015, 1:33 PM
mmel removed rS FreeBSD src repository - subversion as the repository for this revision.
mmel marked an inline comment as done.Nov 18 2015, 1:37 PM

Good catch! Moreover, sl->dataoffs becomes superfluous because we have physical address in all cases. And sorry for my delay...

jah accepted this revision.Nov 18 2015, 3:20 PM
jah edited edge metadata.
This revision is now accepted and ready to land.Nov 18 2015, 3:20 PM
Closed by commit rS291018: ARM: Fix dma_dcache_sync() for early allocated memory. (authored by mmel). · Explain WhyNov 18 2015, 4:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
45 lines

Diff 10086

View Options

sys/arm/arm/busdma_machdep-v6.c

Loading...