schedgraph.py: port to Python 3
ClosedPublic
Actions

Authored by avg on Dec 23 2021, 10:24 AM.

Details

Reviewers

• rodrigc
jhb
jeff
rstone

Commits

rG7e8ed296e120: schedgraph.py: port to Python 3

Summary

The change does not preserve compatibility with Python 2.7.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Errors

Severity	Location	Code	Message
Error	tools/sched/schedgraph.py:39	E265	PEP8 E265
Error	tools/sched/schedgraph.py:41	E265	PEP8 E265
Error	tools/sched/schedgraph.py:42	E265	PEP8 E265
Error	tools/sched/schedgraph.py:43	E265	PEP8 E265
Error	tools/sched/schedgraph.py:44	E265	PEP8 E265
Error	tools/sched/schedgraph.py:47	E265	PEP8 E265
Error	tools/sched/schedgraph.py:138	E302	PEP8 E302
Error	tools/sched/schedgraph.py:155	E302	PEP8 E302
Error	tools/sched/schedgraph.py:170	E302	PEP8 E302
Error	tools/sched/schedgraph.py:191	E711	PEP8 E711
Error	tools/sched/schedgraph.py:195	E101	PEP8 E101
Error	tools/sched/schedgraph.py:195	E128	PEP8 E128
Error	tools/sched/schedgraph.py:196	E101	PEP8 E101
Error	tools/sched/schedgraph.py:196	E128	PEP8 E128
Error	tools/sched/schedgraph.py:200	E302	PEP8 E302
Error	tools/sched/schedgraph.py:217	E302	PEP8 E302
Error	tools/sched/schedgraph.py:238	E101	PEP8 E101
Error	tools/sched/schedgraph.py:238	E128	PEP8 E128
Error	tools/sched/schedgraph.py:240	E101	PEP8 E101
Error	tools/sched/schedgraph.py:240	E128	PEP8 E128
Error	tools/sched/schedgraph.py:242	E101	PEP8 E101
Error	tools/sched/schedgraph.py:242	E128	PEP8 E128
Error	tools/sched/schedgraph.py:244	E101	PEP8 E101
Error	tools/sched/schedgraph.py:244	E128	PEP8 E128
Error	tools/sched/schedgraph.py:278	E302	PEP8 E302

Unit

No Test Coverage

Build Status

Buildable 43575
Build 40463: arc lint + arc unit

Event Timeline

avg created this revision.Dec 23 2021, 10:24 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 23 2021, 10:24 AM

avg requested review of this revision.Dec 23 2021, 10:24 AM

Harbormaster completed remote builds in B43555: Diff 100494.Dec 23 2021, 10:24 AM

I used to program in Python many years ago, but I am not very good with it now.
This is my attempt to make the script work with Python 3 as it is the default Python now.

It may be worthwhile fixing the code style in the script to conform to PEP8, etc just to appease linters, code editors, etc.

jmg added a subscriber: jmg.Dec 23 2021, 11:00 PM

jmg added inline comments.

tools/sched/schedgraph.py
800	Looks like you might want to add @total_ordering to class EventSource from functools. For more information: https://portingguide.readthedocs.io/en/latest/comparisons.html and the decorator definition: https://docs.python.org/3/library/functools.html#functools.total_ordering This will complete the port from single func cmp to the new Python 3 method.