dnctl: Support reading config from file like ipfw(8)
ClosedPublic
Actions

Authored by kp on Dec 23 2021, 2:51 PM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG9d406e088e95: dnctl: Support reading config from file like ipfw(8)

Summary

Extend the dnctl (dummynet config) tool to be able to read commands from
a file, just like ipfw already does.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43557
Build 40445: arc lint + arc unit

Event Timeline

kp created this revision.Dec 23 2021, 2:51 PM

Herald added subscribers: donner, imp. · View Herald TranscriptDec 23 2021, 2:51 PM

kp requested review of this revision.Dec 23 2021, 2:51 PM

Harbormaster completed remote builds in B43557: Diff 100496.Dec 23 2021, 2:51 PM

Looks like there's some whitespace adjustment included too. Will that be a separate commit?

In D33627#760102, @cy wrote:

Looks like there's some whitespace adjustment included too. Will that be a separate commit?

I didn't intend for there to be any, other than increasing the indent level of the while ((c = getopt(ac, av, "cfNnp:qS")) != -1) loop, and as far as I can tell that's the only whitespace change.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 3 2022, 12:56 PM

Closed by commit rG9d406e088e95: dnctl: Support reading config from file like ipfw(8) (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG9d406e088e95: dnctl: Support reading config from file like ipfw(8).

Revision Contents
Changeset List

Path

Size

sbin/

ipfw/

main.c

121 lines

Diff 100496

View Options

dnctl: Support reading config from file like ipfw(8)ClosedPublicActions