Page MenuHomeFreeBSD
Differential D33421

powerpc: adjust FreeBSD kernel backward compatibility list
ClosedPublic
Actions

Authored by alfredo on Dec 13 2021, 10:07 PM.
Tags
Referenced Files
Unknown Object (File)
Tue, Dec 3, 1:15 AM
Unknown Object (File)
Mon, Dec 2, 9:29 PM
Unknown Object (File)
Nov 2 2024, 4:30 AM
Unknown Object (File)
Oct 20 2024, 3:30 PM
Unknown Object (File)
Sep 27 2024, 3:17 AM
Unknown Object (File)
Sep 20 2024, 12:47 AM
Unknown Object (File)
Sep 18 2024, 4:27 PM
Unknown Object (File)
Sep 18 2024, 6:54 AM
View All 90 Files
Subscribers
bdragon
imp
jhibbits
luporl
pkubaj

Details

Reviewers
imp
jhibbits
pkubaj
Group Reviewers
PowerPC
Commits
rGc3b6408ee82b: powerpc: FreeBSD kernel compatibility cleanup
Summary

Adjust FreeBSD kernel backward compatibility list

Test Plan

Run "make buildkernel" for the affected targets

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43352
Build 40240: arc lint + arc unit

Event Timeline

alfredo created this revision.Dec 13 2021, 10:07 PM
Herald added subscribers: luporl, bdragon, jhibbits, imp. · View Herald TranscriptDec 13 2021, 10:07 PM
alfredo requested review of this revision.Dec 13 2021, 10:07 PM
Harbormaster completed remote builds in B43326: Diff 99959.Dec 13 2021, 10:07 PM
alfredo updated this revision to Diff 99961.Dec 13 2021, 10:32 PM

updated after discussion on IRC

Harbormaster completed remote builds in B43327: Diff 99961.Dec 13 2021, 10:32 PM
imp added a comment.Dec 13 2021, 11:50 PM

I'd be sorely tempted to commit the style changes separately.
Also, I thought that we broke powerpc bin-compat with ELFv2. if so, all these lists are way too long :)

pkubaj added a subscriber: pkubaj.Dec 13 2021, 11:57 PM
In D33421#755638, @imp wrote:

Also, I thought that we broke powerpc bin-compat with ELFv2. if so, all these lists are way too long :)

This is about kernel, not userland. While you can't execute binaries built for older releases on newer systems, you can have a new kernel and e.g. old chroot or jail.

imp accepted this revision.Dec 14 2021, 12:11 AM

Makes sense. In that case, I think this is good

This revision is now accepted and ready to land.Dec 14 2021, 12:11 AM
alfredo updated this revision to Diff 100023.Dec 14 2021, 9:04 PM
alfredo edited the summary of this revision. (Show Details)
This revision now requires review to proceed.Dec 14 2021, 9:04 PM
Harbormaster completed remote builds in B43352: Diff 100023.Dec 14 2021, 9:04 PM
imp added a comment.Dec 14 2021, 9:18 PM

looking better! Thanks for splitting out the style changes.
Just a couple of bits of feedback for comments.

sys/powerpc/conf/GENERIC64LE
70

I'd add a rust version here, as well as adding it to the other config files for which it's relevant

sys/powerpc/conf/MPC85XXSPE
68

Why don't the last two have the /powerpc binaries?

alfredo added inline comments.Dec 14 2021, 9:49 PM
sys/powerpc/conf/MPC85XXSPE
68

MPC85XXSPE (powerpcspe) was introduced by FreeBSD 12 according to arch(7), so originally I'd remove compatibility with 10 and 11.
However, after discussion on powerpc64 IRC channel, we concluded that *FreeBSD/powerpcspe* is able to run any *FreeBSD/powerpc* binary/userland, so COMPAT options should be in sync. I'd like to have something to remember us in the future that compat 6-11 is there for that specific reason, but yeah, text looks misleading.

Should I get rid of text "/powerpc binaries" on all lines and explain the reason as a full line comment before COMPAT_FREEBSD6 instead?

imp added inline comments.Dec 14 2021, 10:29 PM
sys/powerpc/conf/MPC85XXSPE
68

Should I get rid of text "/powerpc binaries" on all lines and explain the reason as a full line comment before COMPAT_FREEBSD6 instead?

I think that would be better.

alfredo updated this revision to Diff 100614.Dec 27 2021, 3:10 PM

add ports package versions and adjust comments

Harbormaster completed remote builds in B43608: Diff 100614.Dec 27 2021, 3:11 PM
alfredo marked 3 inline comments as done.Dec 27 2021, 3:11 PM
jhibbits accepted this revision.Jan 6 2022, 6:10 PM
This revision is now accepted and ready to land.Jan 6 2022, 6:10 PM
pkubaj requested changes to this revision.Jan 24 2022, 10:21 PM

sys/powerpc/conf/MPC85XXSPE also includes COMPAT_43. That should also be removed.

This revision now requires changes to proceed.Jan 24 2022, 10:21 PM
pkubaj added a comment.Jan 24 2022, 10:29 PM

Or maybe not, I can see some ARM configs also have this, along with comment [KEEP THIS!].

pkubaj accepted this revision.Mar 7 2022, 2:23 PM
This revision is now accepted and ready to land.Mar 7 2022, 2:23 PM
Closed by commit rGc3b6408ee82b: powerpc: FreeBSD kernel compatibility cleanup (authored by alfredo). · Explain WhyMar 7 2022, 2:32 PM
This revision was automatically updated to reflect the committed changes.
alfredo added a commit: rGc3b6408ee82b: powerpc: FreeBSD kernel compatibility cleanup.

Revision Contents
Changeset List

PathSize
sys/
powerpc/
conf/
2 lines
1 line
4 lines
11 lines

Diff 100023

View Options

sys/powerpc/conf/GENERIC

Loading...
View Options

sys/powerpc/conf/GENERIC64

Loading...
View Options

sys/powerpc/conf/GENERIC64LE

Loading...
View Options

sys/powerpc/conf/MPC85XXSPE

Loading...