cam.3: note that cam_freeccb(3) with ccb == NULL is a no-op
ClosedPublic
Actions

Authored by ngie on Mar 12 2017, 5:52 AM.

Details

Reviewers

ken
imp

Group Reviewers

manpages

Commits

rS315186: lib/libcam/cam.3: note that cam_freeccb(3) with ccb == NULL is a no-op

Summary

lib/libcam/cam.3: note that cam_freeccb(3) with ccb == NULL is a no-op

This allows me to accurately test this scenario, and for others to rely
on the behavior, instead of relying on knowledge obtained via code
inspection.

Wording borrowed from free(3).

MFC after: 1 week
Requested by: ken (D9928)
Sponsored by: Dell EMC Isilon

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Mar 12 2017, 5:52 AM

Herald added a reviewer: manpages. · View Herald TranscriptMar 12 2017, 5:52 AM

Herald added a subscriber: imp. · View Herald Transcript

ngie retitled this revision from lib/libcam/cam.3: note that cam_freeccb(3) is a no-op to lib/libcam/cam.3: note that cam_freeccb(3) with ccb == NULL is a no-op.Mar 12 2017, 6:06 AM

ngie edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B8005: Diff 26171.Mar 12 2017, 8:16 AM

Note that the text doesn't match the description. The description is missing the word 'NULL' I think.

This revision is now accepted and ready to land.Mar 12 2017, 4:31 PM

Forget what I said about anything being missing, other than my ability to read for comprehension.

In D9969#206070, @imp wrote:

Forget what I said about anything being missing, other than my ability to read for comprehension.

The first submission description was a bit wonky. It makes sense why it was missed :).

Closed by commit rS315186: lib/libcam/cam.3: note that cam_freeccb(3) with ccb == NULL is a no-op (authored by ngie). · Explain WhyMar 13 2017, 2:12 AM

This revision was automatically updated to reflect the committed changes.

ngie mentioned this in rS315186: lib/libcam/cam.3: note that cam_freeccb(3) with ccb == NULL is a no-op.

wblock added a subscriber: wblock.Mar 17 2017, 3:51 PM

wblock added inline comments.

head/lib/libcam/cam.3
309	Not always, but sometimes if/then sentences can be clearer or less halting by reversing the order and removing the comma (pause). For instance: No action is taken if .Va ccb is .Dv NULL .

ngie marked an inline comment as done.Mar 17 2017, 11:10 PM

ngie added inline comments.

head/lib/libcam/cam.3
309	nod

ngie marked 2 inline comments as done.Mar 17 2017, 11:10 PM

Revision Contents
Changeset List

Path

Size

head/

lib/

libcam/

cam.3

5 lines

Diff 26201

View Options

lib/libcam/cam.3: note that cam_freeccb(3) with ccb == NULL is a no-opClosedPublicActions